330876 - Weird Dialog for History Item Properties that is also Bookmarked

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ben Goodger (CC only: Do not assign bugs to this!)]

When I choose Properties for an item in history that is also bookmarked, I get this dialog:

+----------------------------------------------------+
| Bookmark Properties                                |
+----------------------------------------------------+
|     Name [ Mozilla Firefox Start Page            ] |
| Location [ http://www.google.com/...             ] |
| Shortcut [                                       ] |
|                                                    |
|  (( Save Changes )) ( Delete Bookmark ) ( Cancel ) |
+----------------------------------------------------+

This is weird, because I clicked on a history item. 

I'm not sure quite what I'd expect to see, since the information that can be presented for a history item is pretty small, but it isn't properties for the same URL bookmarked somewhere else. 

Sorry for the go-around on this one Joe... I thought it might be useful but after using it it's just weird. 

For now, I'd just disable Properties... on history items.

Comment 1

[Joe Hughes]

Attachment: Removes "History Properties" mode from the Bookmark Properties dialog, grays out "Properties" option in context menu when item is a non-bookmarked URI

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 218754 [details] [diff] [review]
Removes "History Properties" mode from the Bookmark Properties dialog, grays out "Properties" option in context menu when item is a non-bookmarked URI

>Index: browser/components/places/content/controller.js
>+   * @returns true if the node represents a bookmarked URI, false otherwise
>+   */
>+
>+  nodeIsBookmark: function PC_nodeIsBookmark(node) {
>+    NS_ASSERT(node, "null node");

nit: nl between comment and fn defn. 

sr=[e-mail]

Comment 3

[Joe Hughes]

Landed on branch and trunk.  Also see related bug 334418.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv