334472 - Device manager dialog does not resize properly when using Extra Large Fonts theme

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Tim Miao]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050607 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1

This bug makes some buttons hiden to users.

Reproducible: Always

Steps to Reproduce:
1. Change gnome theme settings, select Launch bar->Desktop->Preferences->Theme,
select High ContrastInverse theme, then click Theme Details button. Select
Controls tab and set HighContrastLargePrintInverse, select Icon tab and set
HighContrastInverse. Then close these two setting dialog.
2. Go to preferences->Advanced tab->Security->Security Devices, Device Manager window pops up.

Actual Results:  
The buttons were covered in current setting window.

Expected Results:  
Buttons should be visible always in window.

This bug can be found on vermillion_09/snv_36 with Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1. 
If this window was resized to fit the content size, this bug would not be reproducible.

Attached screenshots.

Comment 1

[Tim Miao]

Attachment: Screenshot-1

Comment 2

[Tim Miao]

Attachment: Screenshot-2

Comment 3

[Aaron Leventhal]

Report a broken website often shows this problem: bug 302054

Comment 4

[Mark Pilgrim (inactive)]

Confirmed on Windows as well, using High Contrast Blank (extra large) theme from Accessibility Options control panel.

Comment 5

[Mark Pilgrim (inactive)]

Attachment: Remove hardcoded width/height in advanced.js

The problem is in advanced.js, which opens the dialog with a hard-coded width and height (in pixels).  Removing this allows the dialog to size itself properly according to font size.

This patch also fixes the "View Certificates" and "Revocation Lists" dialog, which have the same problem.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 222870 [details] [diff] [review]
Remove hardcoded width/height in advanced.js

r=mano pending trunk baking.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 222870 [details] [diff] [review]
Remove hardcoded width/height in advanced.js

a=drivers, please land on the 1.8.1 branch

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/preferences/advanced.js 	1.15.2.10
mozilla/browser/components/preferences/advanced.js 	1.24

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381