Get suiterunner to actually run (start up a somewhat usable browser window)

RESOLVED FIXED

Status

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: kairo, Assigned: kairo)

Tracking

Other Branch
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 4 obsolete attachments)

1.36 KB, patch
neil
: review+
Details | Diff | Splinter Review
6.50 KB, patch
neil
: review+
Details | Diff | Splinter Review
3.78 KB, patch
Details | Diff | Splinter Review
1.36 KB, patch
Details | Diff | Splinter Review
3.23 KB, patch
neil
: review+
Details | Diff | Splinter Review
6.39 KB, patch
neil
: review+
Details | Diff | Splinter Review
676 bytes, patch
neil
: review+
Details | Diff | Splinter Review
Assignee

Description

13 years ago
Currently "suiterunner" (SeaMonkey trunk with MOZ_XUL_APP=1) is building correctly on two of three tier-1 platforms, but it's not able to start up correctly yet.
This bug is for patches that enable us to start up a somewhat usable browser window.
Assignee

Updated

13 years ago
No longer blocks: suiterunner
Assignee

Comment 1

13 years ago
This patch makes suiterunner find the Navigator window and set the default theme.
Attachment #218809 - Flags: superreview?(neil)
Attachment #218809 - Flags: review?(neil)
Comment on attachment 218809 [details] [diff] [review]
set prefs to find navigator XUL and set theme correctly

browser.chromeURL is very much needed. Also you should note that  toolkit.chromeURI is a stop-gap until our default command line handler works.
Attachment #218809 - Flags: superreview?(neil)
Attachment #218809 - Flags: superreview-
Attachment #218809 - Flags: review?(neil)
Attachment #218809 - Flags: review-
Assignee

Comment 3

13 years ago
OK, added a comment about the default command line handler and removed the else branch so that browser.defaultURL is also set for suiterunner
Attachment #218809 - Attachment is obsolete: true
Attachment #218813 - Flags: superreview?(neil)
Attachment #218813 - Flags: review?(neil)
Comment on attachment 218813 [details] [diff] [review]
default prefs changes, v2 (checked in)

>+// XXX When SeaMonkey becomes a full xul app the non-moz_xul_app part of this
>+// can be removed.
Oops ;-)
Attachment #218813 - Flags: superreview?(neil)
Attachment #218813 - Flags: superreview+
Attachment #218813 - Flags: review?(neil)
Attachment #218813 - Flags: review+
Assignee

Comment 5

13 years ago
Comment on attachment 218813 [details] [diff] [review]
default prefs changes, v2 (checked in)

sorry again for checkin this in early.
Fixed the comment to
// XXX When SeaMonkey becomes a full xul app this can be set without an ifdef
Attachment #218813 - Attachment description: default prefs changes, v2 → default prefs changes, v2 (checked in)
Assignee

Comment 6

13 years ago
Somehow the extra "platform" on the communicator-platform registration line is causing XML errors, so remove it. Additionally, add xpcnativewrappers for all those lines.
Attachment #219069 - Flags: superreview?(neil)
Attachment #219069 - Flags: review?(neil)
Assignee

Comment 7

13 years ago
Comment on attachment 219069 [details] [diff] [review]
communicator chrome registration changes

Removing "pltform" is actually wrong. We have to convert locale over to the new registration model instead.
Attachment #219069 - Attachment is obsolete: true
Attachment #219069 - Flags: superreview?(neil)
Attachment #219069 - Flags: review?(neil)
Assignee

Comment 8

13 years ago
This one should fix the inconsistency seen in communicator-platform in a better way. The region, xpcnativewrappers and communicator/contents.rdf changes are not strictly needed, but those should happen anyways at some point and are easily done along with this patch, so I've included them.
The good thing is that only the content part of the registration in the xpfe jar.mn is used by thunderbird, the locale stuff is completely forked into mail/ so we can just move it to suite without further thinking.
Those files are small enough to go without cvs moves, IMO (which also enables us to make it happen fast).
Attachment #219086 - Flags: superreview?(neil)
Attachment #219086 - Flags: review?(neil)
a) I'm not convinced on the moves b) I think we need to register overlays
Assignee

Comment 10

13 years ago
Here's a "minimal" patch for correcting the communicator chrome registration stuff. This includes the missing overlays and also branding though (ifdefed to be used by suite only).
Note that we hardcode en-US locale here, as we don't use any @AD_CD@ replacing in that file yet, and it makes no sense to introducethe ability to do so right now - we'll win that by moving that over to suite/locales/ later in a different bug.
Attachment #219086 - Attachment is obsolete: true
Attachment #219205 - Flags: superreview?(neil)
Attachment #219205 - Flags: review?(neil)
Attachment #219086 - Flags: superreview?(neil)
Attachment #219086 - Flags: review?(neil)
Assignee

Comment 11

13 years ago
Comment on attachment 219205 [details] [diff] [review]
make communicator chrome register correctly (checked in)

OH, BTW, in the new overlay lines this also removes the double-overlaying of imageContextOverlay.xul done in contents.rdf (this has r+sr=jag over IRC)
Comment on attachment 219205 [details] [diff] [review]
make communicator chrome register correctly (checked in)

Nit: xpcnativewrappers=yes
Attachment #219205 - Flags: superreview?(neil)
Attachment #219205 - Flags: superreview+
Attachment #219205 - Flags: review?(neil)
Attachment #219205 - Flags: review+
Assignee

Comment 13

13 years ago
(In reply to comment #12)
> (From update of attachment 219205 [details] [diff] [review] [edit])
> Nit: xpcnativewrappers=yes

Argh, sure, I had that in the other patch, got lost when doing the new one, changed locally for checkin (which I'll do first thing tomorrow when I get up)...
Assignee

Comment 14

13 years ago
Comment on attachment 219205 [details] [diff] [review]
make communicator chrome register correctly (checked in)

This one's checked in as well (along with the xpcnativewrappers=yes flags)
Attachment #219205 - Attachment description: make communicator chrome register correctly → make communicator chrome register correctly (checked in)
With this patch I get useful stuff: primary toolbars, help, JS console etc ;-)
Assignee

Comment 16

13 years ago
(In reply to comment #15)
> Created an attachment (id=219285) [edit]
> Patch to kill toolkit chrome for test purposes
> 
> With this patch I get useful stuff: primary toolbars, help, JS console etc ;-)

This sure is only for test purposes, as bsemdberg surely won't let us introduce another set of bad and masty ifdefs into toolkit. We really should work on moving most stuff we need there out of the chrome://global/ namespace (and into chrome://communicator/ probably) or use the toolkit equivalents where provided.
The help stuff looks to me like something that should change on the toolkit side though.

Only to be used for testing in conjunction with the previous patch.
Assignee

Updated

13 years ago
Blocks: suiterunner
There are some scary changes to nsBrowserInstance.cpp which is because there's no way to expose the default page (which for an upgrade is the override page) in the way we used to be able to do.
Assignee

Comment 19

13 years ago
Comment on attachment 219298 [details] [diff] [review]
Functional default command line handler

>+# XXX browser-prefs.js should be moved to within the /suite directory at

Yes, browser-pref.js should move here, but the comment is incomplete ;-)
Assignee

Comment 20

13 years ago
toolkit packages its own help locale files into the locale .jar, and that interferes with extensions/help filling up help locale.

This patch fixes help by overriding the two locale files that we want to package (in tier_99) but toolkit already has packed them (in tier_50).
Attachment #219302 - Flags: superreview?(neil)
Attachment #219302 - Flags: review?(neil)
Comment on attachment 219302 [details] [diff] [review]
make help locale work (checked in)

Somewhat annoying, but at least it doesn't seem to conflict with symlinked chrome.
Attachment #219302 - Flags: superreview?(neil)
Attachment #219302 - Flags: superreview+
Attachment #219302 - Flags: review?(neil)
Attachment #219302 - Flags: review+
Assignee

Comment 22

13 years ago
Comment on attachment 219302 [details] [diff] [review]
make help locale work (checked in)

Checked in this fix as well :)
Attachment #219302 - Attachment description: make help locale work → make help locale work (checked in)
Assignee

Comment 23

13 years ago
This patch makes us use the toolkit console as JS console, and removes some other, now unused xpfe files from suiterunner chrome along withg the xpfe console files.
We may later want to overlay the console to give us a menubar, but for now, we have a working JS console again (and one more piece of toolkit we're using).
Attachment #219332 - Flags: superreview?(neil)
Attachment #219332 - Flags: review?(neil)
Assignee

Updated

13 years ago
Blocks: 334997
Assignee

Comment 24

13 years ago
(In reply to comment #23)
> We may later want to overlay the console to give us a menubar, but for now, we
> have a working JS console again (and one more piece of toolkit we're using).

I've filed bug 334997 for that, and I'm working on a patch for it.
No longer blocks: 334997
Comment on attachment 219332 [details] [diff] [review]
use toolkit console, remove old xpfe files (checked in)

Nit: you can exclude finddialog and filepicker too.
Attachment #219332 - Flags: superreview?(neil)
Attachment #219332 - Flags: superreview+
Attachment #219332 - Flags: review?(neil)
Attachment #219332 - Flags: review+
Assignee

Comment 26

13 years ago
Comment on attachment 219332 [details] [diff] [review]
use toolkit console, remove old xpfe files (checked in)

Checked in this, along with the removal of finddialog and filepicker files from suiterunner.
Attachment #219332 - Attachment description: use toolkit console, remove old xpfe files → use toolkit console, remove old xpfe files (checked in)

Updated

13 years ago
Depends on: 335550
Assignee

Updated

13 years ago
Depends on: 335739
Assignee

Updated

13 years ago
Depends on: 282188
Assignee

Comment 27

13 years ago
Comment on attachment 219298 [details] [diff] [review]
Functional default command line handler

This has been obsoleted by bug 335550
Attachment #219298 - Attachment is obsolete: true
Assignee

Updated

13 years ago
Depends on: 338571
Assignee

Comment 28

13 years ago
Mac suiterunner misses most of our theme files currently. We are actually running into a very similar problem to bug 338571 there: We are "packaging" the files into the app bundle on in suite/app and only after that we are adding the remaining files into the <theme>.jar files - and they never get shipped.
Because of that, we need to build themes before suite/ and then it works as it should, this patch does just that.
Attachment #222715 - Flags: superreview?(neil)
Attachment #222715 - Flags: review?(neil)

Updated

13 years ago
Attachment #222715 - Flags: superreview?(neil)
Attachment #222715 - Flags: superreview+
Attachment #222715 - Flags: review?(neil)
Attachment #222715 - Flags: review+
Assignee

Comment 29

13 years ago
Comment on attachment 222715 [details] [diff] [review]
build themes before suite for correct mac packaging (checked in)

Checked in as well.
Attachment #222715 - Attachment description: build themes before suite for correct mac packaging → build themes before suite for correct mac packaging (checked in)
Blocks: 348381
Assignee

Comment 30

13 years ago
OK, marking this one fixed. It actually has been "somewhat" usable for some time now, all further work that is to be done is marked as dependencies of bug 328887, including the currently biggest dogfood stopper, bug 350221.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.