335739 - [suiterunner] File and Edit menu have no labels and have missing entries

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Frank Wein [:mcsmurf]]

I noticed in current suiterunner builds under Windows the labels in the menubar are missing (just blank space) and also in the menus itself some labels of menu entries are missing (like the Work Offline label, Undo, Cut, Copy, Paste and some others).

Comment 1

[Robert Kaiser]

This has been caused by Axel's checkin for bug 328956, as he unveiled that we were still accessing the releaseURL entity from global-region/region.dtd which he correctly removed from toolkit (see the chrome error at the bottom of the screen).
This should live in suite-specific code of course, either communicator-region or branding.

Comment 2

[Robert Kaiser]

Attachment: move releaseURL to branding for suiterunner

I chose to move it to branding as we already have a .dtd there, while communicator-region only has a .properties and both would be correct to about the same extent IMO.
The Makefile needs to forward the app version var though so that we can use it in the URL.

Comment 3

[[e-mail]]

Comment on attachment 220084 [details] [diff] [review]
move releaseURL to branding for suiterunner

>\ No newline at end of file
>\ No newline at end of file
r+sr=me with these fixed. The first one was particularly silly, as your edits weren't at the end of the file :-P

Comment 4

[Robert Kaiser]

Checked in.

BTW, for any developer listening in this bug: NEVER ever add ifdefs to locale files!
That said, this one is temporarily needed so that brand.dtd and region.dtd don't clash in xpfe-based suite - but plase don't follow that example in other places.