334579 - Button label is not visible in HighContrastInverse theme.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tim Miao]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050607 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1

This bug makes 'No Grouping' button invisible in HighContrastInverse theme.

Reproducible: Always

Steps to Reproduce:
1. Change gnome theme settings, select Launch bar->Desktop->Preferences->Theme,
select High ContrastInverse theme, then click Theme Details button. Select
Controls tab and set HighContrastLargePrintInverse, select Icon tab and set
HighContrastInverse. Then close these two setting dialog.
2. Launch Firefox and go to top menu History->Search in History.
3. Move mouse cursor above 'No Grouping' button.

Actual Results:  
Label of this button is not visible.

Expected Results:  
The label should be visible and compliant with theme settings.

This bug can be found on vermillion_09/svn_36 with Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1.

Comment 1

[Tim Miao]

This bug is also visible when you select Subscriptions in left pane, then move mouse cursor above 'Group By Feed' button.

Comment 2

[Tim Miao]

Attachment: Screenshots

Comment 3

[Tim Miao]

Attachment: Screenshots

Comment 4

[Ginn Chen]

The problem is toolkit/themes/gnomestripe/global/toolbarbutton.css#114

106 /* ..... checked state ..... */
107 
108 toolbarbutton[checked="true"] {
109   border-color: ThreeDShadow ThreeDHighlight ThreeDHighlight ThreeDShadow !important;
110   padding-top: 4px !important;
111   padding-bottom: 2px !important;
112   -moz-padding-start: 4px !important;
113   -moz-padding-end: 2px !important;
114   background-image: url("chrome://global/skin/toolbar/Lighten.png");
115   color: ButtonText !important;
116 }

Comment 5

[Mark Pilgrim (inactive)]

Places-dependent, retargetting for Firefox 3.

Comment 6

[Ginn Chen]

The patch in Bug 334596 solved this bug.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Minusing blocking1.8.1 per comment 5 and comment 6, since it doesn't appear to be an issue for Firefox 2.

Comment 8

[Ginn Chen]

solved by bug 334596

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 10

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381