334596 - [gnome] "No Grouping" "Group By" buttons are same style no matter checked or not

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Ginn Chen]

Launch Firefox and go to top menu History->Search in History.
Click "No Grouping" or "Group by Site" toolbar button.
They are same style no matter checked or not.
So user don't know which one is checked.

This bug is not reproducible on Windows.

Comment 1

[Leon Sha]

Attachment: patch

Comment 2

[Aaron Leventhal]

Comment on attachment 222458 [details] [diff] [review]
patch

No response from Mconnor in 40+ days.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 222458 [details] [diff] [review]
patch

I can't test linux-specific changes, so passing this one back to mconnor, sorry.

Comment 4

[Asaf Romano (gone)]

Mike, see comment 3 please.

Comment 5

[Leon Sha]

Checking in toolkit/themes/gnomestripe/global/toolbarbutton.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/toolbarbutton.css,v  <--  toolbarbutton.css
new revision: 1.11; previous revision: 1.10
done

Comment 6

[Marek Stępień [:marcoos, inactive]]

Note that this is just a poor and ugly workaround, not respecting the GTK theme, causing the buttons to move after each of them is clicked, etc.

For a real fix waiting for months to be checked in, see Bug 254002 (which this one should be marked as duplicate of).