334598 - Buttons in print preview page are not visible in HighContrastInverse theme.

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P3)

Description

[Tim Miao]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050607 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1

The Previous, First Page, Next and Last Page button are not visible when user set desktop theme to HighContrastInverse theme.

Reproducible: Always

Steps to Reproduce:
1. Change gnome theme settings, select Launch bar->Desktop->Preferences->Theme,
select High ContrastInverse theme, then click Theme Details button. Select
Controls tab and set HighContrastLargePrintInverse, select Icon tab and set
HighContrastInverse. Then close these two setting dialog.
2. Launch firefox and load http://www.sun.com/ .
3. Select top menu File->Print Preview.

Actual Results:  
The Previous, First Page, Next and Last Page button are not visible when user set desktop theme to HighContrastInverse theme.

Expected Results:  
These buttons should be visible and compliant with desktop theme settings.

Comment 1

[Tim Miao]

This bug can be found on vermillion_09/snv_36 with Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20060416 Firefox/3.0a1.

Comment 2

[Mark Pilgrim (inactive)]

Confirmed on Windows as well.

Comment 3

[Mark Pilgrim (inactive)]

Attachment: Add labels to home/previous/next/end buttons

I added short labels to each button so they appear in high contrast mode.

Comment 4

[Aaron Leventhal]

Comment on attachment 222865 [details] [diff] [review]
Add labels to home/previous/next/end buttons

No response from Mconnor in 35+ days.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 222865 [details] [diff] [review]
Add labels to home/previous/next/end buttons

well, I responded to mark on IRC when the patch was attached, and assumed he'd clear the nomination since this makes the window too big to fit in 800x600

Comment 6

[Mark Pilgrim (inactive)]

Sorry, I didn't know it was socially acceptable to futz with other people's review flags (even if I was the one who requested it).

Comment 7

[Aaron Leventhal]

(In reply to comment #6)
> Sorry, I didn't know it was socially acceptable to futz with other people's
> review flags (even if I was the one who requested it).

It's okay sometimes if it's obviously the right thing -- like if they accidentally requested it from the wrong person etc.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

This'll block the beta2 milestone for now. If we can get it sooner, great!

Comment 9

[Mark Pilgrim (inactive)]

Well I can't add descriptive labels to the buttons because it makes the toolbar too wide (> 800px).  And the icons seem to disappear in certain themes because they're black.  Can I change the icons to green?  That doesn't really solve the problem in the general case, and it might just spawn additional bugs ("Icons in print preview are not compliant with themes" or some such).

Attaching a patch that uses text to denote the arrows, plus some script that changes their direction based on locale, to match the old CSS chomedir logic.  If this solution is not acceptable, I'm tempted to mark this WONTFIX, since all options seem to be exhausted.

Comment 10

[Mark Pilgrim (inactive)]

Attachment: patch to use text for navigation arrows

As described in previous comment.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 228156 [details] [diff] [review]
patch to use text for navigation arrows

dir="reverse"!?

Anyway, if you need to set labels from a script, use a stringbundleset instead and query the ui-direction using window.getComputedStyle (as in tabbrowser.xml for example).

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 228156 [details] [diff] [review]
patch to use text for navigation arrows

I can't say that the current print preview icons are gorgeous enough to not happily replace them with some text label buttons. Until we fix this window elsewhere (it's so horrible, makes everyone cry!) I'm fine with this solution.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Not a regression from 1.5, so we're not going to block. But we'd take that patch if it gets written.

Comment 14

[Wayne Mery (:wsmwk)]

WFM Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a2pre) Gecko/20100217 Minefield/3.7a2pre

Comment 15

[Dão Gottwald [:dao]]

Attachment: patch v2

I didn't localize the labels since these symbols should work universally (just like the image icons).

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/fa0934fbb4d5
Use Unicode symbols in print preview page navigation buttons. r=felipe

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa0934fbb4d5

Comment 18

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381