334602 - [FIX]ASSERTION: Reparenting something that has no usable parent? Shouldn't happen!: 'Not Reached'

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Martijn Wargers (dead)]

See upcoming testcase, which gives this assertion in current trunk build.
Basically, it is these styles rules that cause the assertion:
html::first-line { }
html::before { content:"This should not give an assertion in Mozilla";}

This assertion was added with the fix for bug 322348.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Mats Palmgren (inactive)]

This leads to a crash for me (SeaMonkey debug Linux):
1. load testcase
2. CTRL++ (zoom in)

The reason for the assertion is that GetParentStyleContextFrame()
returns early if there is no parent content:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsFrame.cpp&rev=3.660&root=/cvsroot&mark=4818-4821#4811

and we come here from nsCSSFrameConstructor::WrapFramesInFirstLineFrame
on the root content. See attached stack.

Comment 3

[Mats Palmgren (inactive)]

Attachment: assertion stack + crash stack

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Pseudo-elements are not the root....

Comment 5

[Boris Zbarsky [:bzbarsky]]

We need this on the branches (and I'll probably try to land it on 1.7 as well....)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 230366 [details] [diff] [review]
Fix

r+sr=dbaron

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 230366 [details] [diff] [review]
Fix

This is a very safe crash fix.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230366 [details] [diff] [review]
Fix

a=drivers for MOZILLA_1_8_BRANCH

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 230366 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz for drivers

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8.0.7 and 1.8.1

Comment 12

[Jesse Ruderman]

Crashtest checked in.