Closed
Bug 334776
Opened 19 years ago
Closed 19 years ago
loadOneTab should treat null as undefined for the aLoadInBackground argument
Categories
(Firefox :: General, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha2
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.43 KB,
patch
|
asaf
:
review+
asaf
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Since bug 331522 landed, aLoadInBackground is no longer the last argument, so it should be compared to null instead of undefined so that people don't have to explicitly pass in undefined.
|
Assignee | |
Comment 1•19 years ago
|
||
(false != null) == true
(undefined != null) == false
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #219105 -
Flags: review?(mconnor)
Attachment #219105 -
Flags: approval-branch-1.8.1?(mconnor)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 219105 [details] [diff] [review]
patch
r+181=mano.
Attachment #219105 -
Flags: review?(mconnor)
Attachment #219105 -
Flags: review+
Attachment #219105 -
Flags: approval-branch-1.8.1?(mconnor)
Attachment #219105 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checked in on the trunk, waiting for tree to open for the branch.
mozilla/toolkit/content/widgets/tabbrowser.xml 1.145
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•19 years ago
|
||
mozilla/toolkit/content/widgets/tabbrowser.xml 1.103.2.35
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•