335291 - Make trunk spellchecker popup events safer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Brett Wilson]

The branch spellchecker on bug 329668 will have enhanced security checks and some attributes moved around. These changes should be ported back to the trunk.

Comment 1

[Boris Zbarsky [:bzbarsky]]

We need this for alpha, imo.

Comment 2

[Brett Wilson]

Attachment: Patch

Comment 3

[Brett Wilson]

The patch basically copies GetRangeParent/Offset from the branch, and makes the accessors from JS the same as the branch patch.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 223049 [details] [diff] [review]
Patch

You should change the uuid of nsIDOMXULDocument, right?

Comment 5

[Brett Wilson]

Attachment: Patch with UUID

Thanks, this patch changes the UUID as well.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 223087 [details] [diff] [review]
Patch with UUID

>Index: dom/public/idl/xul/nsIDOMXULDocument.idl
>+   * Like trustedGetPopupNode, but gets the 
>+   */

The which?

>Index: content/xul/document/src/nsXULDocument.cpp
>+nsXULDocument::GetPopupRangeParent(nsIDOMNode** aRangeParent)

>+    if (NS_SUCCEEDED(rv) && *aRangeParent &&
>+            !nsContentUtils::CanCallerAccess(*aRangeParent)) {

Fix the indent here?

>+nsXULDocument::GetPopupRangeOffset(PRInt32* aRangeOffset)

>+    if (parent && !nsContentUtils::CanCallerAccess(parent))
>+        return NS_ERROR_DOM_SECURITY_ERR;

Brace the if body please?

r=bzbarsky with those nits fixed.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Brett: are you going to check this in soon? If not, can you revert the bits of this that landed and caused bug 340320?