340320 - spell checking (suggestions) broken

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060604 Minefield/3.0a1 ID:2006060407 [cairo]

repro:
1.type some text in a textarea, make a little mistake and check the spelling

result:
the misspelled word is underlined, but no suggestions

regressionwindow:
works in 20060502 1326 pdt build
fails in 20060502 1543 pdt build

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1149277440&maxdate=1149284939

Comment 1

[Wesley Johnston (:wesj)]

Broke on Linux too. Can someone change this to all?

Comment 2

[TimoT]

Some extra bits got accidentally checked in with the fix for bug 216899, backing them out fixes this.

http://tinderbox.mozilla.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser.js&rev1=1.634&rev2=1.635&root=/cvsroot

Comment 3

[TimoT]

Attachment: backout extra bits from bug 216899

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 340832 has been marked as a duplicate of this bug. ***

Comment 5

[Martijn Wargers (dead)]

So I guess the patch can be checked in without a review, since that code was checked in accidently anyway?

Comment 6

[Martijn Wargers (dead)]

Ah sorry, Brett checked the patch for bug 216899 in, so he probably caused this hiccup.

Comment 7

[Brett Wilson]

This was fixed by landing bug 335291 which is where the accidental bits came from.

Comment 8

[Fahmida Noor]

I have reproduced this bug with Firefox 3.0a1 on Windows 7(64-bit) with the instructions from comment 0.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9a1) Gecko/20060604 Minefield/3.0a1

Verified as fixed with Latest Firefox Beta 44.0b7 (Build ID : 20160107144911)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

[testday-20160108]