Closed Bug 335296 Opened 15 years ago Closed 15 years ago

Give tinderbox client the ability to start building xulrunner+firefox

Categories

(Webtools Graveyard :: Tinderbox, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

This is a first step: currently all of the tests and bit-shipping must be disabled in tinder-config, but it at least produces a green tree that builds correctly.
Blocks: 315452
Rob, ping?
Comment on attachment 219659 [details] [diff] [review]
add SubObjDir, and allow not to check binary for executable, rev. 1

Looks good to me, preed should look it over as well.
Attachment #219659 - Flags: review?(rhelmer)
Attachment #219659 - Flags: review?(preed)
Attachment #219659 - Flags: review+
Comment on attachment 219659 [details] [diff] [review]
add SubObjDir, and allow not to check binary for executable, rev. 1

# subdirectory: example "firefox/" - NOTE: need trailing slash!

Can you assert this somewhere?

A quick:

die 'ASSERT: $SubObjDir needs a trailing slash!' if ($Settings::SubObjDir ne '' && $Settings::SubObjDir !~ m:/$:); before this is used would be helpful.

Other than that, r=preed.
Attachment #219659 - Flags: review?(preed) → review+
Blocks: 341547
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.