Closed Bug 335457 Opened 18 years ago Closed 18 years ago

[FIX]Make URI vs originalURI code consistent in document and docshell

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Right now, documents and docshells do different things wrt originalURI vs URI for incoming data.  We should really fix that.
Attached patch Proposed patchSplinter Review
I'd like this on the 1.8.1 branch too; Ben's feed stuff is broken without this.

Note that this affects behavior of two cases:

  chrome/resource/about originalURI and LOAD_REPLACE set.  This currently does
     not happen.
  some other originalURI and LOAD_REPLACE not set.  Since current HTTP redirects
     do set LOAD_REPLACE, we'd ok.

In any case, this makes documents sorta follow the nsIChannel docs on what LOAD_REPLACE means.
Attachment #219818 - Flags: superreview?(jst)
Attachment #219818 - Flags: review?(cbiesinger)
Attachment #219818 - Flags: approval-branch-1.8.1?(jst)
Summary: Make URI vs originalURI code consistent in document and docshell → [FIX]Make URI vs originalURI code consistent in document and docshell
Marking blocking-1.8.1, as long as this is in the critical path for feed handling
Flags: blocking1.8.1+
Attachment #219818 - Flags: superreview?(jst) → superreview+
Comment on attachment 219818 [details] [diff] [review]
Proposed patch

r=dveditz

Should regression-check bug 251368
Attachment #219818 - Flags: review?(cbiesinger) → review+
Did that.  It looks good.

Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
A local backout shows that this caused bug 337339
Depends on: 337339
Attachment #219818 - Flags: approval-branch-1.8.1?(jst) → approval1.8.1?
Bz - do we need both this and bug 337339 for 1.8.1?
Hmm...  I believe we need this for bug 325085, right?  If so, we probably do need this on the 1.8.1 branch, and then we need a fix for bug 337339 there.  Unfortunately, the patch for bug 337339 can't be used on the branch as-is; we'd need to either take an entirely different approach or at the very least add an nsIURIFixup_MOZILLA_1_8_BRANCH if we decide removing keyword: on the branch is ok...
Holding the approval on this until we get a branch patch for the regression bug 337339 - would be great to land that and this together.
Comment on attachment 219818 [details] [diff] [review]
Proposed patch

Clearing nomination so we don't go over it again at each triage meeting.  Please renominate once it's ready (see previous comment).
Attachment #219818 - Flags: approval1.8.1?
Comment on attachment 219818 [details] [diff] [review]
Proposed patch

OK, the regression fix landed.  So this is good to go for branch.
Attachment #219818 - Flags: approval1.8.1?
Attachment #219818 - Flags: approval1.8.1? → approval1.8.1+
Fixed on 1.8 branch.
Keywords: fixed1.8.1
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: