335747 - crash when an extension is disabled and the next is selected (in addons manager new style) (with some versions of Console2 extension installed) [@ xpcom_core.dll]

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 ID:2006042712 [cairo]

repro:

1.Open Addons manager
2.Select an extension and press on the disable button
3.Select another extension

result:
crash

talkback: TB18048040H TB18048210G

Comment 1

[Robert Strong (they/them - no direct email)]

I haven't seen this and I haven't been able to reproduce it with WinXP. I'll try to get one of my Win2K VM's working in the next few days and will hopefully be able to reproduce it so I can debug it.

Comment 2

[Dave Townsend [:mossop]]

I see this in Windows XP on Pacific build 2006042706 on Windows XP

TB18048302W

It crashes every time when disabling, and most of the time after enabling as well.

Comment 3

[u88484]

Was just about to file this, TB18045944Y

Comment 4

[Nikola Kocić]

I can reproduce it with

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 ID:2006042706 [cairo]

Talkback TB18050463G

Comment 5

[Robert Strong (they/them - no direct email)]

I am still unable to reproduce on WinXP using the latest gauis trunk. I've disabled / enabled several extensions repeatedly by clicking then clicking the next extension, by using the keyboard shortcut and the arrow key to select the next extension, and combinations of both of those and have not experienced a single crash using the latest gauis trunk. I've also tried with a debug build and still no crash.

Comment 6

[Robert Strong (they/them - no direct email)]

For the heck of it try to reproduce in safe mode

Comment 7

[Régis Caspar]

(In reply to comment #6)
> For the heck of it try to reproduce in safe mode
Can reproduce on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 ID:2006042706 [cairo] but can't reproduce in -safe-mode

Comment 8

[Régis Caspar]

(In reply to comment #7)
> Can reproduce on Mozilla/5.0 ...
Forgot TB#: TB18051131K

Comment 9

[Robert Strong (they/them - no direct email)]

I'm wonderring if it may be due to NTT extending the EM. Also, I noticed NTT is continually dumping msgs about talkback to the console on my debug build... it even continued to dump for about a minute after I exited.

Comment 10

[Régis Caspar]

(In reply to comment #9)
> I'm wonderring if it may be due to NTT extending the EM. Also, I noticed NTT is
> continually dumping msgs about talkback to the console on my debug build... it
> even continued to dump for about a minute after I exited.
I got one with NTT disabled (TB18051394X). 

BTW: I got the same crash on re-enabling: TB18051307Z

Comment 11

[Régis Caspar]

Sorry for the bugspam, I forgot again something, this is not only "the next", the crash occurs when any other extension is clicked.

Comment 12

[Robert Strong (they/them - no direct email)]

Since I can't reproduce and it doesn't happen in safe mode could someone disable all their extensions, restart, then re-enable one at a time including a restart, and try to reproduce this (e.g. narrow down whether it is an installed extension causing this)? Thanks

Comment 13

[u88484]

Still crash with NTT disabled. Rob, sometimes I can't reproduce it and then I restart and try again and can.

Comment 14

[Robert Strong (they/them - no direct email)]

Right... comment #12 are the next steps that should be taken. Thanks

Comment 15

[Nikola Kocić]

It seems that Console2 0.3.4 extension causes this crash.

Comment 16

[Peter van der Woude [:Peter6]]

(In reply to comment #15)
> It seems that Console2 0.3.4 extension causes this crash.
> 
Confirmed, no crahes when Console² 0.3.4 is disabled

Comment 17

[u88484]

Also, confirming Console2 0.3.4

Comment 18

[Régis Caspar]

(In reply to comment #17)
> Also, confirming Console2 0.3.4
Me too, and adding a workaround:
from Console²'s chrome.manifest:
# remove these two lines, if don't want to take advantage of Console²'s richlistbox
override	chrome://global/content/bindings/richlistbox.xml	chrome://console2/content/richlistbox.xml
override	chrome://global/skin/richlistbox.css	chrome://console2/skin/richlistbox.css

Commenting (#) the two override fix the problem.

Comment 19

[Robert Strong (they/them - no direct email)]

Well, the Add-ons Mgr doesn't support replacing the richlistbox implementation that comes with the application. I'll look at the patch to implement multi-select for the richlistbox which iirc is essentially what is provided by Console 2 to see if it is something we want to consider for 2.0 and what would be needed to get the Add-ons Mgr using it.

If you experience this bug you will need to disable Console 2... this will probably end up being resolved -> invalid since this is to be expected when an extension modifies the default functionality provided by the app.

Comment 20

[Simon Bünzli]

I'm not able to reproduce the crash with the current testing version of Console² (0.3.4.4+). Those of you experiencing this issue: please update and verify that the problem has already been resolved.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 ID:2006042706

(In reply to comment #19)
> Well, the Add-ons Mgr doesn't support replacing the richlistbox implementation
> that comes with the application.

Neither did the old Extensions manager. That's nothing you have to explicitly support but which should work as long as you use the binding's official APIs and don't rely on internals (which AFAICT you do/don't).

> this is to be expected when an
> extension modifies the default functionality provided by the app.

This is /not/ to be expected. <richlistbox> is implemented purely in XBL and so is Console²'s replacement. At this level, you simply shouldn't be able to crash the application. Just because it's my extension which triggers/exposes this issue doesn't make this bug invalid.

Comment 21

[Robert Strong (they/them - no direct email)]

(In reply to comment #20)
> I'm not able to reproduce the crash with the current testing version of
> Console� (0.3.4.4+). Those of you experiencing this issue: please update and
> verify that the problem has already been resolved.
Good to hear

> Neither did the old Extensions manager. That's nothing you have to explicitly
> support but which should work as long as you use the binding's official APIs
> and don't rely on internals (which AFAICT you do/don't).
I did override one method primarily due to richlistbox not supporting selection without focus (AFAICT).

> This is /not/ to be expected. <richlistbox> is implemented purely in XBL and so
> is Console�'s replacement.
The trouble is it replaced / changed existing behavior used by the components of the app and when that is done things will break as has been seen previously. It isn't that the implementation in Console 2 is bad (as a matter of fact I like it) - it is just different.

> At this level, you simply shouldn't be able to crash
> the application. Just because it's my extension which triggers/exposes this
> issue doesn't make this bug invalid.
Agree wholeheartedly in regards to the crash... I'm referring to the EM portion of this. Regretfully, I don't have time to investigate why the crash occured due to other committments and if it is left in the EM component chances are it won't get any attention due to it being misfiled which is something I have been trying to change for quite some time now.

Comment 22

[Régis Caspar]

(In reply to comment #20)
> I'm not able to reproduce the crash with the current testing version of
> Console² (0.3.4.4+). Those of you experiencing this issue: please update and
> verify that the problem has already been resolved.

No crash when using Console² 0.3.4.4+, confirmed

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060427 Minefield/3.0a1 ID:2006042706 [cairo]

Comment 23

[Dave Townsend [:mossop]]

*** Bug 344918 has been marked as a duplicate of this bug. ***

Comment 24

[Dave Townsend [:mossop]]

*** Bug 348713 has been marked as a duplicate of this bug. ***

Comment 25

[Ropp]

*** Bug 348714 has been marked as a duplicate of this bug. ***

Comment 26

[Dave Townsend [:mossop]]

If there was a stack I would imagine it would point at layout/xul being the real location of the crash, not the add-ons manager. I'm going to close this because we don't really have useful information to do anything with any longer. If anyone has the urge to reproduce with an old console2 and file a bug in the appropriate place then feel free.