335878 - non-ascii search engine names are not correctly displayed

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Hiro]

A Japanese original report is http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=5136 

Reproducible: Always

Steps to Reproduce:
1. Open URL.
2. Install search engin of "産経新聞 記事検索".
    (The link is "javascript:addEngine. ('sankei','png','Search')")
3. See Search Engin pulldown menu and Search Engin Manager.


Windows NT, Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060428 Minefield/3.0a1

Comment 1

[Hiro]

Attachment: Screen shot of Search Engin pulldonw menu

Comment 2

[Hiro]

Attachment: Screen shot of Search Engin Manager

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Which character encoding are the files in? This worked correctly using the old search service (Firefox 1.5)?

Comment 4

[Hiro]

In Firefox1.5.0.2 release, there is no problem. 
The character code of tried Search Engin is Shif-JIS.
 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP-mac; rv:1.8.0.2) Gecko/20060328 Firefox/1.5.0.2

Comment 5

[Hiro]

Attachment: File of search engin installed in Profile

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Do searches using non-ascii characters work correctly?

Comment 7

[Phil Ringnalda (:philor)]

The character encoding for the .src file itself is supposed to come from sourceTextEncoding, an int in the set in MapScriptCodeToCharsetName(). And http://r09.org/sh/engine/sankei.src does indeed have sourceTextEncoding = "1", which says it's in Shift-JIS.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Bah, I shouldn't have missed that.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I believe this fixes it. If anyone could test this patch out I would very much appreciate it. I'm going to be away for a little bit, I want to check this over again before asking for review.

Comment 10

[Hiro]

(In reply to comment #9)
> Created an attachment (id=220276) [edit]
> patch

This patch was tried. 
The installation of build and the search engine works normally. 
I do not think that there is basically a problem. 

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Thank you for the testing.

This patch only affects loading of engines done through window.addSearchEngine(), I need to make it work for engines copied to the searchplugins folder manually as well.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch v2

Make the sherlock byte translating code common and make both code paths use it. More testing on this would be great. Copying files to the profile and app dir directly and loading files from the web both need to be tested, with as many character sets and sourceTextEncoding combinations as possible.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk.

Comment 14

[Hiro]

I tried tinderbox-builds.
And commnet#0 doesn't have the problem.

But the problem still reproduced by following search plugin...
(These plug-ins do not have the problem before either. )

http://guide.search.goo.ne.jp/apply/firefox/install.php

javascript:add_goo('11goo_eiwa', 'gif', 'goo%E8%BE%9E%E6%9B%B8(%E8%8B%B1%E5%92%8C)','11goo_eiwa');

javascript:add_goo('12goo_waei', 'gif', 'goo%E8%BE%9E%E6%9B%B8(%E5%92%8C%E8%8B%B1)','12goo_waei');

javascript:add_goo('13goo_kokugo_shingo', 'gif', 'goo%E8%BE%9E%E6%9B%B8(%E5%9B%BD%E8%AA%9E)','13goo_kokugo_shingo');

Windows XP SP1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060516 Minefield/3.0a1

Comment 15

[Hiro]

Attachment: Screen shot after "goo search plugin" is installed

The plug-in of commnet#0 is correctly displayed. 
But "goo search plugin" is not displayed still correctly.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #15)
> The plug-in of commnet#0 is correctly displayed. 
> But "goo search plugin" is not displayed still correctly.

Thanks a lot for testing this - I filed bug 338252 on this new issue, I will try to fix that as soon as possible.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Checked in on the branch for a3.
mozilla/browser/components/search/nsSearchService.js 	1.1.2.20