sourceTextEncoding attribute isn't parsed correctly in all cases (certain Sherlock plugins don't display correctly)

RESOLVED FIXED in Firefox 2 beta1

Status

()

Firefox
Search
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta1
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If the sourceTextEncoding attribute in a Sherlock file has a space after the equals sign, it fails to parse and the file's encoding isn't recognized.

We should keep the byte array around until we start the actual parsing, and then re-convert later if we see a sourceTextEncoding attribute. That way we can avoid regex hacks and just use the normal Sherlock attribute parser to parse sourceTextEncoding.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Priority: -- → P1
Target Milestone: --- → Firefox 2 alpha3
Created attachment 222579 [details] [diff] [review]
patch

I've tested it with the plugins from bug 335878 comment 14, and from bug 335878 comment 0, but more extensive testing is always appreciated. I want to double check a few things before asking for review.

Comment 2

12 years ago
(In reply to comment #1)
> Created an attachment (id=222579) [edit]
> patch
> 
> I've tested it with the plugins from bug 335878 comment 14, and from bug 335878
> comment 0, but more extensive testing is always appreciated. I want to double
> check a few things before asking for review.
> 

I tried this patch.
The problem of bug 335878 comment 14 is solved, too. 
There seems to be no problem though other search plugin was tried. 
Please go ahead.
Comment on attachment 222579 [details] [diff] [review]
patch

Thanks again for the testing Hiro!
Attachment #222579 - Flags: review?(mconnor)
Attachment #222579 - Flags: approval-branch-1.8.1?(mconnor)
--> beta1
Target Milestone: Firefox 2 alpha3 → Firefox 2 beta1
Whiteboard: [patch-r?]
Comment on attachment 222579 [details] [diff] [review]
patch

} else

should be

}
else

otherwise, r+a=me
Attachment #222579 - Flags: review?(mconnor)
Attachment #222579 - Flags: review+
Attachment #222579 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #222579 - Flags: approval-branch-1.8.1+
mozilla/browser/components/search/nsSearchService.js 	1.1.2.24
mozilla/browser/components/search/nsSearchService.js 	1.28
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Flags: blocking-firefox2?
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [patch-r?]
You need to log in before you can comment on or make changes to this bug.