Closed Bug 336474 Opened 19 years ago Closed 19 years ago

Upgrade developer-stage wikis to MediaWiki 1.6.5

Categories

(mozilla.org Graveyard :: Server Operations, task)

Product:
mozilla.org Graveyard
Component:
Server Operations
Platform:
All
Other
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: deb, Assigned: deb)

References

Details

Attachments

(1 file)

Breadcrumbs Fix for MW 1.6
822 bytes, patch
Details | Diff | Splinter Review
The 1.6 MW series has some features we would like to start taking advantage of at the MDC, but we need to verify that our skins and extensions will continue working properly once upgraded. Getting the developer-stage.mozilla.org wikis upgraded will allow us to do the required testing.
Assignee: server-ops → oremj
I "know" breadcrumbs won't work properly, I can attach a patch here, or file a new bug... I'll leave that up to you, dria.
Breadcrumbs seem to be working. In what way should they break?
http://bonsai-www.mozilla.org/cvsblame.cgi?file=devmowiki/extensions/Breadcrumbs.php&rev=&root=/cvsroot&mark=51#45 That line should be written >= and not test against a string, (php will convert the $wgVersion string to a float for us in that test). We *want* to use the page table here.
See also: http://developer-stage.mozilla.org/en/docs/Sandbox:BreadTest:subpage Should be "Main Page > Sandbox > BreadTest > subpage" but we are missing the two pages here, probably only getting Sandbox due to namespace stuffs... (I'm not really sure).
Callek, do you have a fix for the breadcrumb problem? It's pretty broken for sure, and I can't test the title-override stuff because of the brokenness. Here, for example: http://developer-stage.mozilla.org/en/docs/Foobar I'll check the skins and such to make sure they're ok. At first glance both devmo and mdc versions of the skins look fine.
This *should* do it, and at least as far as my quick glance is concerned, title-override should be ok.
i've got MySQL error on -stage/ja site. "1146: Table 'devmowiki-test.ja2_job' doesn't exist (mrdb01.mozilla.org)" i think this may cause current ja's error.
I wouldn't be suprised if much of the site was working. I'm going to try to restructure the cvs repository so it is easier for future mediawiki merges.
It looks like gandalf's external-redirects modifications are no longer working (he's working on a new patch), but the single-sign-on stuff is.
Blocks: 296085
I finished merging in 1.6.5 any ideas why sso isn't working?
Nevermind I got it working. 1.6 switches to wgCookiePath in the login function instead of just using wgDBname. Also the breadcrumb patch has been commited. Let me know if there is anything else I can do before I close this bug.
both blocking bugs have patches ready to use
Blocks: 305760
Japanese version is still just producing a blank page, and stage appears to be missing a korean version: http://developer-stage.mozilla.org/ja/docs/ http://developer-stage.mozilla.org/ko/docs/ The wiki-images/ directory also needs to be copied from developer.mozilla.org to developer-stage.mozilla.org (I think) -- as it stands all the uploaded images are missing (except the firefox logo on the front page of the EN wiki because I reuploaded that one).
The japan and korean wikis are now working and I have synced up the wiki-images directory with the one on the live site.
Reassigning to Deb.
Assignee: oremj → deb
The Japanese wiki on dev-stage looks wrong -- all the question marks should be proper japanese characters, as I understand it. The last time we ran into a problem like this it was related to the database import or export. Polvi sorted out how to fix it last time, so he might have a better idea of what's specifically involved. http://developer-stage.mozilla.org/ja/docs/ Still testing other aspects of the upgrade.
Assignee: deb → oremj
(In reply to comment #16) > The Japanese wiki on dev-stage looks wrong -- all the question marks should be > proper japanese characters, as I understand it. The last time we ran into a > problem like this it was related to the database import or export. Polvi > sorted out how to fix it last time, so he might have a better idea of what's > specifically involved. i agree with dria. it seems that problem is the same as bug #298552's one. we should import dumped data with UTF-8 language mode. # or set MySQL database charactor code to UTF-8, and set "init-connect = SET NAMES binary;" to my.cnf (we do this on bugzilla.mozilla.gr.jp)
I've encountered a couple of other issues that we'll need to resolve one way or another. 1) If it hasn't already been applied, gandalf's patch from bug 305760 needs to be applied. As it stands, external redirects don't work at all. 2) We need the ImageLink.php extension added to the GlobalSettings. The extension is in the extensions directory, it just hasn't been included in GlobalSettings yet. I'm not sure which file needs to be changed here. 3) There's something weird with the cache or title-override. When creating a new page with a title override, the override title doesn't display in the breadcrumb the first time the page is saved. It takes two or usually three page saves for it to appear. On the current MDC wikis, the title displays on the first save. Everything else I tested appears to be OK.
I will try and look into the title-override bug, (if its something apparanent from my end.)
Looks like the mysqldump has to have --default-character-set=latin1. Japanese character set looks fixed.
I've also applied the external redirect patch and added the imagelink extension.
Something bad happened between yesterday and today and I'm not sure what it could be. It looks like the single-sign-on stuff is causing problems, but I'm not entirely sure. When hitting the site with no cookies and then logging in, I get the following error: --- A database query syntax error has occurred. This may indicate a bug in the software. The last attempted database query was: (SQL query hidden) from within function "User::loadFromDatabase". MySQL returned error "1054: Unknown column 'user_registration' in 'field list' (mrdb01.mozilla.org)". --- When hitting the site with a logged in cookie, I get this error: --- A database error has occurred Query: SELECT user_name,user_password,user_newpassword,user_email,user_email_authenticated,user_real_name,user_options,user_touched,user_token,user_registration FROM `devmowiki-test`.`mediawikiuser` WHERE user_id = '2' LIMIT 1 Function: User::loadFromDatabase Error: 1054 Unknown column 'user_registration' in 'field list' (mrdb01.mozilla.org) Backtrace: GlobalFunctions.php line 602 calls wfbacktrace() Database.php line 473 calls wfdebugdiebacktrace() Database.php line 419 calls databasemysql::reportqueryerror() Database.php line 806 calls databasemysql::query() Database.php line 825 calls databasemysql::select() User.php line 720 calls databasemysql::selectrow() User.php line 667 calls user::loadfromdatabase() Setup.php line 223 calls user::loadfromsession() index.php line 80 calls require_once() --- I believe gandalf (who i'm cc'ing here) has included a new SSO patch in bug 296085, and I'm not sure whether that's been applied yet or not. I'm just not sure why SSO seemed to work yesterday but appears to be broken today, unless the external redirect patch is causing this?
No, it's a problem with bad upgrade of database, it has nothing to do with SSO patch. The database structure was not properly upgraded between 1.5.x and 1.6.5 probably.
Mediawiki's update script fails to add one column on devmo. Anyways, the problem has been fixed.
Ok, it looks like almost all of the problems I encountered before have been fixed (Imagelink, external redirects, and SSO stuff). The only major issue remaining (beyond a fix i need to make to one of the skins) is that the title-override changes seem to be getting stuck in the cache (or something). I figure that either something in the extension has changed that is causing this, or the cache settings are different between developer-stage.mo and developer.mo, unless someone can think of some other possible cause for this? Callek, let me know when you get a chance to poke at the extension. I'm going to send a mail out to dev-mdc asking for help testing the upgraded wikis on developer-stage now, to see if anyone else can find any major issues.
shaver requested a new bug be opened for title-override issues. # 337987 is that new bug.
Title-override bug has been fixed by shaver. See 337987 for details.
With title overrides working is this bug finished?
Just going to do one last round of testing (I've asked the folks on dev-mdc to help) before closing it out. Reassigning to myself.
Assignee: oremj → deb
Finished.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: