336527 - Expose toolkitName and version to AT-SPI

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Spinoff from bug 309789.

There is a toolkitName and version in the Accessibility interface for AT-SPI:
http://gnome.org/~billh/at-spi-new-idl/html/html/classAccessibility_1_1Application.html

We should expose the Gecko version number and use either "Mozilla", "Gecko" or "xulrunner" as the toolkitName.

Not sure how to expose it in ATK.

Comment 1

[Willie Walker]

Look for the string "get_toolkit" in this file to see how gail sets up the toolkit name and version using atk:

  http://cvs.gnome.org/viewcvs/*checkout*/gail/gail/gailutil.c

Since you refer to it as exposing the "Gecko version number," I guess calling it "Gecko" might be a good choice.  :-)

Will

Comment 2

[Ginn Chen]

Attachment: patch

Comment 3

[Aaron Leventhal]

Comment on attachment 221278 [details] [diff] [review]
patch

I thought Will said we weren't exposing a toolkitName it all. According to this patch, it would currently be "mozilla".

Comment 4

[Aaron Leventhal]

Ah, I just tested with at-poke and we are exposing the toolkit name as Mozilla. Let's keep the toolkit name as "Mozilla" since nobody knows what "Gecko" is anymore. The two names have become synonymous.

The toolkit is "Mozilla" with version "1.8" or "1.9"
The app name is "Firefox", and not "Mozilla Firefox". I'm not sure if there is a way to expose the application version.

Ginn, can you make that change? You still have r+=aaronleventhal.

Comment 5

[Aaron Leventhal]

Comment on attachment 221278 [details] [diff] [review]
patch

Please also check into 1.8 branch when it opens.

Comment 6

[Ginn Chen]

Checking in accessible/src/atk/nsAppRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v  <--  nsAppRootAccessible.cpp
new revision: 1.17; previous revision: 1.16
done

Checking in accessible/src/atk/nsAppRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v  <--  nsAppRootAccessible.cpp
new revision: 1.11.26.4; previous revision: 1.11.26.3
done

Comment 7

[Ginn Chen]

*** Bug 237253 has been marked as a duplicate of this bug. ***