336590 - Caret can not be placed after [space] at the end of a wrapped line in textarea, using the mouse

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Niro]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060503 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060503 Minefield/3.0a1

Follow the instructions in the testcase.

Reproducible: Always

Comment 1

[Niro]

Attachment: testcase

Comment 2

[Niro]

Regression range:
20060419 - 20060420

Comment 3

[Ria Klaassen (not reading all bugmail)]

I have some builds in between and the problem happened between 1.9a1_2006041913 and 1.9a1_2006041915. Sounds familiar to me but I can't find the dupe so maybe I'm mistaken.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Bonsai link: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-04-19+12%3A00&maxdate=2006-04-19+15%3A00
Bug 324414 is about a caret. I see no dependencies there.

Comment 5

[Uri Bernstein]

Actually, this is probably due to my fix for bug 334256.

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase2

Probably related to this bug (it has the same regression range)
I get a caret **** at the end of the first line when following the instructions in the testcase.

Comment 7

[Uri Bernstein]

Attachment: patch

nsTypedSelection::setAnchorFocusRange() turned out not to be the right place for fixing bug 334256. The click case reaches this method via nsTypedSelection::Collapse(), after setting the hint correctly.

So I pulled the fix one level up - into nsTypedSelection::AddRange().

Comment 8

[Uri Bernstein]

Checked in:

Checking in layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v  <--  nsSelection.cpp
new revision: 3.238; previous revision: 3.237
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on the trunk using SeaMonkey build 2006-08-05-08 under Windows XP with:


https://bugzilla.mozilla.org/attachment.cgi?id=220771
-and-
https://bugzilla.mozilla.org/attachment.cgi?id=220797

In the former, I can successfully place the cursor/caret after the space using the mouse (it doesn't go to the second line, below), and in the latter I don't get the caret turds like I used to.