336758 - Add pref for repressing Fx2 Session-restore Prompt

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Dietrich Ayala (:dietrich)]

Since tinderbox shuts down the app w/ SIGTERM, and the app doesn't shut down cleanly, Ts and Tp tests fail because the new session-restore prompt prevents the test from getting to page content.

I'm attaching a patch that sets a pref to disable the prompt for the tests.

We need to get this to the build boxes as soon as possible, so we can get the feature turned on in the nightlies. Please let me know what I can do to help expedite this!

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: adds a pref to repress session-restore prompt

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: sets the resume_from_crash pref default to true

needs to go in on trunk and branch, *after* the tinderboxes are updated

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true

r+a=me for 1.8.1 branch after the tbox changes happen

Comment 4

[Robert Helmer [:rhelmer]]

Comment on attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true

r=preed

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to comment #4)
> (From update of attachment 221358 [details] [diff] [review] [edit])
> r=preed
> 

scratch that, reviewing the tbox patch

Comment 6

[Robert Helmer [:rhelmer]]

Comment on attachment 220945 [details] [diff] [review]
adds a pref to repress session-restore prompt

r=preed

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to comment #6)
> (From update of attachment 220945 [details] [diff] [review] [edit])
> r=preed
> 

This has landed, will be picked up by tinderboxes on next build:

Checking in tools/tinderbox/build-seamonkey-util.pl;
/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v  <--  build-seamonkey-util.pl
new revision: 1.318; previous revision: 1.317
done

Comment 8

[Mike Connor [:mconnor]]

default flipped now, resolving as FIXED

Comment 9

[Mike Schroepfer]

Fixed 1.8.1 keyword required?