Add pref for repressing Fx2 Session-restore Prompt

RESOLVED FIXED

Status

Webtools Graveyard
Tinderbox
--
major
RESOLVED FIXED
12 years ago
4 years ago

People

(Reporter: dietrich, Assigned: morgamic)

Tracking

Trunk
All
Mac OS X
Dependency tree / graph

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
Since tinderbox shuts down the app w/ SIGTERM, and the app doesn't shut down cleanly, Ts and Tp tests fail because the new session-restore prompt prevents the test from getting to page content.

I'm attaching a patch that sets a pref to disable the prompt for the tests.

We need to get this to the build boxes as soon as possible, so we can get the feature turned on in the nightlies. Please let me know what I can do to help expedite this!
(Reporter)

Comment 1

12 years ago
Created attachment 220945 [details] [diff] [review]
adds a pref to repress session-restore prompt
(Reporter)

Updated

12 years ago
Blocks: 328154
(Reporter)

Comment 2

12 years ago
Created attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true

needs to go in on trunk and branch, *after* the tinderboxes are updated
Attachment #221358 - Flags: review?(mconnor)
Comment on attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true

r+a=me for 1.8.1 branch after the tbox changes happen
Attachment #221358 - Flags: review?(mconnor) → review+
Comment on attachment 221358 [details] [diff] [review]
sets the resume_from_crash pref default to true

r=preed
Attachment #221358 - Flags: review+
(In reply to comment #4)
> (From update of attachment 221358 [details] [diff] [review] [edit])
> r=preed
> 

scratch that, reviewing the tbox patch
Comment on attachment 220945 [details] [diff] [review]
adds a pref to repress session-restore prompt

r=preed
Attachment #220945 - Flags: review+
Attachment #221358 - Flags: review+
(In reply to comment #6)
> (From update of attachment 220945 [details] [diff] [review] [edit])
> r=preed
> 

This has landed, will be picked up by tinderboxes on next build:

Checking in tools/tinderbox/build-seamonkey-util.pl;
/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v  <--  build-seamonkey-util.pl
new revision: 1.318; previous revision: 1.317
done

Updated

12 years ago
Blocks: 337193
default flipped now, resolving as FIXED
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 9

12 years ago
Fixed 1.8.1 keyword required?
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.