"Link from other application" pref name in Tabs prefPane sounds very awkward

VERIFIED FIXED in Camino1.5

Status

Camino Graveyard
Preferences
--
minor
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1

Details

Attachments

(2 attachments, 2 obsolete attachments)

10.81 KB, application/zip
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details
65.76 KB, image/png
Details
The Tabs prefPane has some pref names singular and some plural; at least one of the singular ones ("Link from other application") sounds really odd.

We should switch 

Link from other application --> Links from other applications
Opens in a new window --> Open in new windows
Opens in a new tab in the frontmost window --> Open in new tabs in the frontmost window
Reuses the frontmost window --> Reuse the frontmost window

This breaks the parallelism with "Command click on link" (for hyperlinks internal to Camino), but I think that's OK here since the current pref name is so awkward, even just in relation to the other pref names in that pane.
(Assignee)

Comment 1

12 years ago
Taking.  I'm gonna wait on bug 184994 to do this though, so there's only one nib change for the prefpane. (any other open bugs to change the tabs prefpane?)
Assignee: nobody → stridey
(Assignee)

Comment 2

12 years ago
Created attachment 227322 [details]
New Tabs.nib
Attachment #227322 - Flags: review?(alqahira)
(Assignee)

Comment 3

12 years ago
Created attachment 227323 [details]
Screenshot
(Assignee)

Comment 4

12 years ago
Created attachment 227372 [details]
New Tabs.nib

Refined on IRC
Attachment #227322 - Attachment is obsolete: true
Attachment #227372 - Flags: review?(alqahira)
Attachment #227322 - Flags: review?(alqahira)
(Assignee)

Comment 5

12 years ago
Created attachment 227373 [details]
Screenshot
Attachment #227323 - Attachment is obsolete: true
Attachment #227372 - Flags: review?(alqahira) → review+
(Assignee)

Updated

12 years ago
Attachment #227372 - Flags: superreview?(mikepinkerton)
Comment on attachment 227372 [details]
New Tabs.nib

looks ok to me. sr=pink
Attachment #227372 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Updated

12 years ago
Whiteboard: [needs checkin]

Comment 7

12 years ago
Fixed, checked in trunk and branch
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]

Comment 8

12 years ago
Verified with latest trunk nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.