Closed Bug 336839 Opened 15 years ago Closed 15 years ago

"Link from other application" pref name in Tabs prefPane sounds very awkward

Categories

(Camino Graveyard :: Preferences, defect)

PowerPC
macOS
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.5

People

(Reporter: alqahira, Assigned: froodian)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 2 obsolete files)

The Tabs prefPane has some pref names singular and some plural; at least one of the singular ones ("Link from other application") sounds really odd.

We should switch 

Link from other application --> Links from other applications
Opens in a new window --> Open in new windows
Opens in a new tab in the frontmost window --> Open in new tabs in the frontmost window
Reuses the frontmost window --> Reuse the frontmost window

This breaks the parallelism with "Command click on link" (for hyperlinks internal to Camino), but I think that's OK here since the current pref name is so awkward, even just in relation to the other pref names in that pane.
Taking.  I'm gonna wait on bug 184994 to do this though, so there's only one nib change for the prefpane. (any other open bugs to change the tabs prefpane?)
Assignee: nobody → stridey
Attached file New Tabs.nib (obsolete) —
Attachment #227322 - Flags: review?(alqahira)
Attached image Screenshot (obsolete) —
Attached file New Tabs.nib
Refined on IRC
Attachment #227322 - Attachment is obsolete: true
Attachment #227372 - Flags: review?(alqahira)
Attachment #227322 - Flags: review?(alqahira)
Attached image Screenshot
Attachment #227323 - Attachment is obsolete: true
Attachment #227372 - Flags: review?(alqahira) → review+
Attachment #227372 - Flags: superreview?(mikepinkerton)
Comment on attachment 227372 [details]
New Tabs.nib

looks ok to me. sr=pink
Attachment #227372 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]
Fixed, checked in trunk and branch
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Verified with latest trunk nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.