336935 - Coverity 172, dead code in mozilla/security/nss/lib/softoken/keydb.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Jon Smirl]

The variable rc4key is not used and can be removed.

diff -r1.40 keydb.c
720d719
<     SECItem *rc4key = NULL;
889,892d887
<     if ( rc4key ) {
<       SECITEM_FreeItem(rc4key, PR_TRUE);
<     }
<

Comment 1

[Jon Smirl]

Attachment: Remove rc4key variable and dead code

Comment 2

[Jon Smirl]

*** Bug 337629 has been marked as a duplicate of this bug. ***

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 221123 [details] [diff] [review]
Remove rc4key variable and dead code

r-, this patch is not a unified diff.  
The other patch for this issue, attached to bug 337629, has received r+.
This bug probably should have been made a dup of the other one, since the other one has the reviewed patch.

Comment 4

[Jon Smirl]

Attachment: Copy of the unified patch that has been +r in 337629.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 221768 [details] [diff] [review]
Copy of the unified patch that has been +r in 337629. 

yeah, r=nelson

Comment 6

[Alexei Volkov]

trunk
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v  <--  keydb.c
new revision: 1.44; previous revision: 1.43
3.11 branch
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v  <--  keydb.c
new revision: 1.40.2.2; previous revision: 1.40.2.1