Closed Bug 336935 Opened 15 years ago Closed 15 years ago

Coverity 172, dead code in mozilla/security/nss/lib/softoken/keydb.c

Categories

(NSS :: Libraries, defect, P3)

3.11
All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.11.2

People

(Reporter: jonsmirl, Assigned: alvolkov.bgs)

References

Details

(Keywords: coverity, Whiteboard: FIPS [CID 172])

Attachments

(1 file, 1 obsolete file)

The variable rc4key is not used and can be removed.

diff -r1.40 keydb.c
720d719
<     SECItem *rc4key = NULL;
889,892d887
<     if ( rc4key ) {
<       SECITEM_FreeItem(rc4key, PR_TRUE);
<     }
<
Hardware: PC → All
Target Milestone: --- → 3.11.2
Version: unspecified → 3.11
Severity: normal → trivial
Priority: -- → P3
Attachment #221123 - Flags: review?(wtchang)
*** Bug 337629 has been marked as a duplicate of this bug. ***
Comment on attachment 221123 [details] [diff] [review]
Remove rc4key variable and dead code

r-, this patch is not a unified diff.  
The other patch for this issue, attached to bug 337629, has received r+.
This bug probably should have been made a dup of the other one, since the other one has the reviewed patch.
Attachment #221123 - Attachment is obsolete: true
Attachment #221123 - Flags: review?(wtchang) → review-
Comment on attachment 221768 [details] [diff] [review]
Copy of the unified patch that has been +r in 337629. 

yeah, r=nelson
Attachment #221768 - Attachment description: Copy of the unified patch that has been +r in 337629. dupe was marked backwards → Copy of the unified patch that has been +r in 337629.
Attachment #221768 - Flags: review+
Attachment #221768 - Flags: review+
trunk
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v  <--  keydb.c
new revision: 1.44; previous revision: 1.43
3.11 branch
/cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v  <--  keydb.c
new revision: 1.40.2.2; previous revision: 1.40.2.1
Assignee: nobody → alexei.volkov.bugs
Whiteboard: FIPS
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #221768 - Flags: review+
Whiteboard: FIPS → FIPS [CID 172]
You need to log in before you can comment on or make changes to this bug.