337629 - Coverity 857, dead code in base/src/mozilla/security/nss/lib/softoken/keydb.c

Status: RESOLVED DUPLICATE of bug 336935

(NSS :: Libraries, defect)

Description

[Jon Smirl]

Unused variable

Index: security/nss/lib/softoken/keydb.c
===================================================================
RCS file: /cvsroot/mozilla/security/nss/lib/softoken/keydb.c,v
retrieving revision 1.40
diff -u -r1.40 keydb.c
--- security/nss/lib/softoken/keydb.c   28 Sep 2005 17:12:17 -0000      1.40
+++ security/nss/lib/softoken/keydb.c   11 May 2006 19:19:48 -0000
@@ -717,7 +717,6 @@
     DBT key;
     DBT data;
     unsigned char version;
-    SECItem *rc4key = NULL;
     NSSLOWKEYDBKey *dbkey = NULL;
     NSSLOWKEYDBHandle *update = NULL;
     SECItem *oldSalt = NULL;
@@ -886,10 +885,6 @@

     nsslowkey_CloseKeyDB(update);

-    if ( rc4key ) {
-       SECITEM_FreeItem(rc4key, PR_TRUE);
-    }
-

Comment 1

[Jon Smirl]

Attachment: remove unused variable

Comment 2

[Jon Smirl]

*** This bug has been marked as a duplicate of 337081 ***

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

This does not appear to be a duplicate of bug 337081 in any way.

Comment 4

[Jon Smirl]

I duped it to the wrong bug. Coverity is assigning different error numbers to the hits on each run. I am going to have to stop until this batch gets checked in. There are 180 hits in mozilla/security and it is getting confusing. Once these are checked in they will disappear in Coverity. Search for keyword coverity.

*** This bug has been marked as a duplicate of 336935 ***

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 221731 [details] [diff] [review]
remove unused variable

r=nelson