336948 - figure out undo/redo model for bookmarks

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm filing this bug because I suspect that any fix for the leaks in bug 168411, whether it's the one described there or a simpler hack, would change the behavior of undo/redo for bookmark transactions (add via dialog, do things via context menu, drag/drop, make all sorts of changes in bookmarks manager) in some way.  I'd pose the following questions:

 * in what windows should undo/redo operate on the bookmark transaction list?  Only the bookmarks manager, or also the browser window?  (IIRC, SeaMonkey lets the browser window's undo/redo operate on bookmarks in some cases; this code may have been removed in Firefox, or it may be dormant and potentially re-awakened by changes for bug 168411.)  (I tend to think only the bookmarks manager, especially if there's no description of what's being undone, such as "Undo Add Bookmark" instead of "Undo"... a la bug 92288, for which similar bugs should probably be filed elsewhere.)

 * How long should the undo/redo queue for bookmarks changes be, i.e., how far back should the user be able to undo?  I'd note that this is an interesting question, since it's possible for bookmarks to be changed in Window A, then Window B, then Window A, then Window B; the changes are reflected in all windows each time.  This one would almost definitely be changed by a fix for bug 168411.

Comment 1

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.