Closed Bug 337154 Opened 15 years ago Closed 15 years ago

Coverity 321, dead code in mozilla/security/nss/lib/pk11wrap/pk11cert.c

Categories

(NSS :: Libraries, defect, P3)

Product:
NSS
Component:
Libraries
Version:
3.11
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
3.11.2

People

(Reporter: jonsmirl, Assigned: alvolkov.bgs)

References

Details

(Keywords: coverity, Whiteboard: [CID 149 321 834])

Attachments

(2 files)

remove dead code in error path
598 bytes, patch
wtc
: review+
Details | Diff | Splinter Review
fix two more places
1.65 KB, patch
nelson
: review+
Details | Diff | Splinter Review 
This is just wrong and should be removed. 

@@ -1319,7 +1319,6 @@
     /* get them all! */
     list = PK11_GetAllTokens(CKM_INVALID_MECHANISM,PR_FALSE,PR_TRUE,wincx);
     if (list == NULL) {
-       if (list) PK11_FreeSlotList(list);
        return CK_INVALID_HANDLE;
     }
Same problem in a different place

@@ -1084,7 +1084,6 @@
     /* get them all! */
     list = PK11_GetAllTokens(CKM_INVALID_MECHANISM,PR_FALSE,PR_TRUE,wincx);
     if (list == NULL) {
-       if (list) PK11_FreeSlotList(list);
        return CK_INVALID_HANDLE;
     }
Attachment #221327 - Flags: review?(wtchang)
Keywords: coverity
Severity: normal → trivial
Priority: -- → P3
Attachment #221327 - Flags: review?(wtchang) → review+
trunk
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v  <--  pk11cert.c
new revision: 1.147; previous revision: 1.146

3.11 branch
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v  <--  pk11cert.c
new revision: 1.143.2.3; previous revision: 1.143.2.2
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee: nobody → alexei.volkov.bugs
reopening.  
This bug is one of several that has several complaints about a file,
and includes a patch that only fixes one of them. 
Checking in the fix for one of them doesn't resolve the whole bug.
Please re-review all the coverity bugs recently marked RESOLVED/FIXED
to make sure that all the problems reported in the bug were fixed, 
and not only just the first one.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #222411 - Flags: review?(nelson)
Comment on attachment 222411 [details] [diff] [review]
fix two more places

r=nelson
Attachment #222411 - Flags: review?(nelson) → review+
second patch:

trunk:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v  <--  pk11cert.c
new revision: 1.150; previous revision: 1.149

3.11 branch:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cert.c,v  <--  pk11cert.c
new revision: 1.143.2.6; previous revision: 1.143.2.5
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Whiteboard: [CID 321]
Also CID 149
Whiteboard: [CID 321] → [CID 149 321]
*** Bug 337633 has been marked as a duplicate of this bug. ***
Whiteboard: [CID 149 321] → [CID 149 321 834]
You need to log in before you can comment on or make changes to this bug.