337196 - build fix for cvs head 2006-05-08

Status: RESOLVED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[Michal Ceresna]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.2) Gecko/20060419 Fedora/1.5.0.2-1.2.fc5 Firefox/1.5.0.2 pango-text
Build Identifier: 

Here is some small build fix to make the javaxpcomglue
export the JNI function.



Reproducible: Always

Comment 1

[Michal Ceresna]

Attachment: build fix

compiler: gcc version 4.1.0 20060304 (Red Hat 4.1.0-3)


the function was in the local scope due to the default gcc switch:
-fvisibility=hidden

Comment 2

[jhp (no longer active)]

Comment on attachment 221370 [details] [diff] [review]
build fix

It's not as simple as adding NS_EXPORT there.  This works fine for Linux and Mac OS X, but Win32 (and OS/2, I believe) woudl define both NS_EXPORT and JNIEXPORT as "__declspec(dllexport)", which works, but leads to warnings.  New patch to follow.

Comment 3

[jhp (no longer active)]

Attachment: patch v2

This doesn't add NS_EXPORT for Win32 and OS/2, so no warning.  Also, I made sure to make JNI_OnLoad and JNI_OnUnLoad visible.  Let me know if this works for you.

Comment 4

[Michal Ceresna]

(In reply to comment #3)
Works also for me. 

Note, I had some rejects when applying the patch due
to some whitespace differences which I had to resolve
manually.

Comment 5

[jhp (no longer active)]

Comment on attachment 221461 [details] [diff] [review]
patch v2

Setting r+ based on comment #4.  Will check in once the trunk is open.

Comment 6

[jhp (no longer active)]

Checked in to trunk.  Will check in to 1.8 branch when it opens.

Comment 7

[jhp (no longer active)]

Comment on attachment 221461 [details] [diff] [review]
patch v2

Seeking approval for 1.8.0.5.  This is a very minor fix to allow these public methods to be properly exported when using GCC's visibility feature.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 221461 [details] [diff] [review]
patch v2

approved for 1.8.0 branch, a=dveditz for drivers