Closed Bug 337196 Opened 17 years ago Closed 17 years ago

build fix for cvs head 2006-05-08

Categories

(Core Graveyard :: Java to XPCOM Bridge, defect)

Product:
Core Graveyard
Component:
Java to XPCOM Bridge
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: michal.ceresna, Assigned: jhpedemonte)

Details

(Keywords: fixed1.8.0.5, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

patch v2
2.26 KB, patch
jhpedemonte
: review+
jhpedemonte
: approval-branch-1.8.1+
dveditz
: approval1.8.0.5+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.2) Gecko/20060419 Fedora/1.5.0.2-1.2.fc5 Firefox/1.5.0.2 pango-text
Build Identifier: 

Here is some small build fix to make the javaxpcomglue
export the JNI function.



Reproducible: Always
Attached patch build fix (obsolete) — — Splinter Review 
compiler: gcc version 4.1.0 20060304 (Red Hat 4.1.0-3)


the function was in the local scope due to the default gcc switch:
-fvisibility=hidden
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 221370 [details] [diff] [review]
build fix

It's not as simple as adding NS_EXPORT there.  This works fine for Linux and Mac OS X, but Win32 (and OS/2, I believe) woudl define both NS_EXPORT and JNIEXPORT as "__declspec(dllexport)", which works, but leads to warnings.  New patch to follow.
Attachment #221370 - Flags: review-
Attached patch patch v2 — — Splinter Review 
This doesn't add NS_EXPORT for Win32 and OS/2, so no warning.  Also, I made sure to make JNI_OnLoad and JNI_OnUnLoad visible.  Let me know if this works for you.
Attachment #221370 - Attachment is obsolete: true
Attachment #221461 - Flags: review?(michal.ceresna)
(In reply to comment #3)
Works also for me. 

Note, I had some rejects when applying the patch due
to some whitespace differences which I had to resolve
manually.
Comment on attachment 221461 [details] [diff] [review]
patch v2

Setting r+ based on comment #4.  Will check in once the trunk is open.
Attachment #221461 - Flags: review?(michal.ceresna) → review+
Checked in to trunk.  Will check in to 1.8 branch when it opens.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #221461 - Flags: approval-branch-1.8.1+
Keywords: fixed1.8.1
Comment on attachment 221461 [details] [diff] [review]
patch v2

Seeking approval for 1.8.0.5.  This is a very minor fix to allow these public methods to be properly exported when using GCC's visibility feature.
Attachment #221461 - Flags: approval1.8.0.5?
Comment on attachment 221461 [details] [diff] [review]
patch v2

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #221461 - Flags: approval1.8.0.5? → approval1.8.0.5+
Flags: blocking1.8.0.5+
Keywords: fixed1.8.0.5
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.