User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:188.8.131.52) Gecko/20060419 Fedora/184.108.40.206-1.2.fc5 Firefox/220.127.116.11 pango-text Build Identifier: Here is some small build fix to make the javaxpcomglue export the JNI function. Reproducible: Always
Created attachment 221370 [details] [diff] [review] build fix compiler: gcc version 4.1.0 20060304 (Red Hat 4.1.0-3) the function was in the local scope due to the default gcc switch: -fvisibility=hidden
Comment on attachment 221370 [details] [diff] [review] build fix It's not as simple as adding NS_EXPORT there. This works fine for Linux and Mac OS X, but Win32 (and OS/2, I believe) woudl define both NS_EXPORT and JNIEXPORT as "__declspec(dllexport)", which works, but leads to warnings. New patch to follow.
Created attachment 221461 [details] [diff] [review] patch v2 This doesn't add NS_EXPORT for Win32 and OS/2, so no warning. Also, I made sure to make JNI_OnLoad and JNI_OnUnLoad visible. Let me know if this works for you.
(In reply to comment #3) Works also for me. Note, I had some rejects when applying the patch due to some whitespace differences which I had to resolve manually.
Comment on attachment 221461 [details] [diff] [review] patch v2 Setting r+ based on comment #4. Will check in once the trunk is open.
Checked in to trunk. Will check in to 1.8 branch when it opens.
Comment on attachment 221461 [details] [diff] [review] patch v2 Seeking approval for 18.104.22.168. This is a very minor fix to allow these public methods to be properly exported when using GCC's visibility feature.
Comment on attachment 221461 [details] [diff] [review] patch v2 approved for 1.8.0 branch, a=dveditz for drivers