Closed
Bug 337196
Opened 18 years ago
Closed 18 years ago
build fix for cvs head 2006-05-08
Categories
(Core Graveyard :: Java to XPCOM Bridge, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michal.ceresna, Assigned: jhpedemonte)
Details
(Keywords: fixed1.8.0.5, fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
2.26 KB,
patch
|
jhpedemonte
:
review+
jhpedemonte
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.5+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.2) Gecko/20060419 Fedora/1.5.0.2-1.2.fc5 Firefox/1.5.0.2 pango-text Build Identifier: Here is some small build fix to make the javaxpcomglue export the JNI function. Reproducible: Always
Reporter | ||
Comment 1•18 years ago
|
||
compiler: gcc version 4.1.0 20060304 (Red Hat 4.1.0-3) the function was in the local scope due to the default gcc switch: -fvisibility=hidden
Updated•18 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•18 years ago
|
||
Comment on attachment 221370 [details] [diff] [review] build fix It's not as simple as adding NS_EXPORT there. This works fine for Linux and Mac OS X, but Win32 (and OS/2, I believe) woudl define both NS_EXPORT and JNIEXPORT as "__declspec(dllexport)", which works, but leads to warnings. New patch to follow.
Attachment #221370 -
Flags: review-
Assignee | ||
Comment 3•18 years ago
|
||
This doesn't add NS_EXPORT for Win32 and OS/2, so no warning. Also, I made sure to make JNI_OnLoad and JNI_OnUnLoad visible. Let me know if this works for you.
Attachment #221370 -
Attachment is obsolete: true
Attachment #221461 -
Flags: review?(michal.ceresna)
Reporter | ||
Comment 4•18 years ago
|
||
(In reply to comment #3) Works also for me. Note, I had some rejects when applying the patch due to some whitespace differences which I had to resolve manually.
Assignee | ||
Comment 5•18 years ago
|
||
Comment on attachment 221461 [details] [diff] [review] patch v2 Setting r+ based on comment #4. Will check in once the trunk is open.
Attachment #221461 -
Flags: review?(michal.ceresna) → review+
Assignee | ||
Comment 6•18 years ago
|
||
Checked in to trunk. Will check in to 1.8 branch when it opens.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Attachment #221461 -
Flags: approval-branch-1.8.1+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Assignee | ||
Comment 7•18 years ago
|
||
Comment on attachment 221461 [details] [diff] [review] patch v2 Seeking approval for 1.8.0.5. This is a very minor fix to allow these public methods to be properly exported when using GCC's visibility feature.
Attachment #221461 -
Flags: approval1.8.0.5?
Comment 8•18 years ago
|
||
Comment on attachment 221461 [details] [diff] [review] patch v2 approved for 1.8.0 branch, a=dveditz for drivers
Attachment #221461 -
Flags: approval1.8.0.5? → approval1.8.0.5+
Updated•18 years ago
|
Flags: blocking1.8.0.5+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.0.5
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•