33801 - Print dialog says "Netscape"

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Daniel Roberts]

Steps to reproduce:

1) Open the "Print" dialog from the File menu.
2) Notice that "netscape.ps" is the default filename for "Print to File."

This kind of thing belongs in Netscape, and not in Mozilla.

Comment 1

[Eli Goldberg]

Reassigning to more appropriate people.

Comment 2

[Eli Goldberg]

<Meaningless comment required by Bugzilla.>

Comment 3

[dcone (gone)]

And I am not sure what the name should be,   

Comment 4

[Mike Shaver (:shaver emeritus)]

Let's use mozilla.ps for now, and switch to url_filename.ps at some later point.

OK, Syd?

Comment 5

[Daniel Roberts]

I now have some patches to fix this bug.  Syd, do you want to review them for

me?  I have CVS access, so I could check them in.

Comment 6

[Syd Logan]

Sure attach the patch here.

Comment 7

[Daniel Roberts]

I can't seem to get bugzilla to work at the moment on attachments, so I'll type


out the patches manually.





"url_filename," as shaver suggests, would be THE most elegant solution yet, but


since I do not know how to do that, I am just doing the "mozilla.ps" change for


now.  Anyone else know how to take it to the next stage?

Comment 8

[Daniel Roberts]

Index: nsDeviceContextSpecG.cpp

===================================================================

RCS file: /cvsroot/mozilla/gfx/src/gtk/nsDeviceContextSpecG.cpp,v

retrieving revision 1.12

diff -r1.12 nsDeviceContextSpecG.cpp

151c151

<               strcpy( mPrData.path, "netscape.ps" );

---

>               strcpy( mPrData.path, "mozilla.ps" );

153c153

<       sprintf( mPrData.path, "%s/netscape.ps", path );

---

>       sprintf( mPrData.path, "%s/mozilla.ps", path );

Comment 9

[Daniel Roberts]

Index: nsDeviceContextSpecB.cpp

===================================================================

RCS file: /cvsroot/mozilla/gfx/src/beos/nsDeviceContextSpecB.cpp,v

retrieving revision 1.2

diff -r1.2 nsDeviceContextSpecB.cpp

81c81

<               strcpy( mPrData.path, "netscape.ps" );

---

>               strcpy( mPrData.path, "mozilla.ps" );

83c83

<       sprintf( mPrData.path, "%s/netscape.ps", path );

---

>       sprintf( mPrData.path, "%s/mozilla.ps", path );

Comment 10

[Daniel Roberts]

Index: nsDeviceContextSpecQT.cpp

===================================================================

RCS file: /cvsroot/mozilla/gfx/src/qt/nsDeviceContextSpecQT.cpp,v

retrieving revision 1.3

diff -r1.3 nsDeviceContextSpecQT.cpp

82c82

<             strcpy(mPrData.path, "netscape.ps");

---

>             strcpy(mPrData.path, "mozilla.ps");

87c87

<         sprintf(mPrData.path, "%s/netscape.ps", path);

---

>         sprintf(mPrData.path, "%s/mozilla.ps", path);

Comment 11

[Mike Shaver (:shaver emeritus)]

Go check it in, Daniel, r=shaver.

And then go run off and figure out how to do the url-thing.

Comment 12

[Daniel Roberts]

Thanks!  I will check in the fix as soon as I get a chance (the fix is at home 
on my Linux box).  I will consider this a temporary fix until I find a way of 
doing "url_filename".html later on.

Comment 13

[Daniel Roberts]

Assigning to myself, since I have decided to take this on.

Comment 14

[Daniel Roberts]

Temporary fix checked in.

Comment 15

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 16

[Mike Shaver (:shaver emeritus)]

I'm marking this fixed.  Let's file an RFE for better print-target naming, if
one of us can muster the energy to care.

Thanks, Daniel.

Comment 17

[shrirang khanzode]

verified (11/08).