338022 - Dead code in buildASN1ObjectFromDER (security/manager/ssl/src/nsNSSASN1Object.cpp)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kenneth Herron]

This is coverity CID 146. Please see the sample URL. The tests at lines 151 and 155 will never succeed, because line 134 will return if |parent| is NULL.

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

First try at a patch, remove dead code.

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 239701 [details] [diff] [review]
Patch v1

It would have been good to use -u20 to include a bit more context, so the patch would clearly show the previous check.

Further up in this function we have:
NS_ENSURE_ARG_POINTER(parent);

And "parent" is not being changed afterwards, so I agree with the patch.

r=kengert

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

(In reply to comment #2)
> (From update of attachment 239701 [details] [diff] [review] [edit])
> It would have been good to use -u20 to include a bit more context, so the patch
> would clearly show the previous check.

I can provide a patch with -u20 as a param if that would be useful.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/security/manager/ssl/src/nsNSSASN1Object.cpp 	1.13