Closed Bug 339749 Opened 19 years ago Closed 10 years ago

unreachable code in buildASN1ObjectFromDER

Categories

(Core :: Security: PSM, defect, P4)

Product:
Core
Component:
Security: PSM
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 338022
Milestone:
mozilla1.9alpha8

People

(Reporter: dveditz, Unassigned)

References

(
URL
)

Details

(Whiteboard: [kerh-cua])

buildASN1ObjectFromDER is passed a parent pointer, not a pointer-to-a-pointer, so attempts to assign things to parent will simply leak. But in fact we don't get this far because NS_ENSURE_ARG_POINTER(parent) will return in the error case. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/manager/ssl/src/nsNSSASN1Object.cpp&rev=1.12&mark=126,134,151-156#124 (found while reviewing bug 283565)
Priority: -- → P4
Whiteboard: [kerh-cua]
Target Milestone: --- → mozilla1.9beta
QA Contact: psm
reassign bug owner. mass-update-kaie-20120918
Assignee: kaie → nobody
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.