Closed Bug 338103 Opened 16 years ago Closed 16 years ago
.dir is "" unless it's set manually
Found while working on bug 337998 (tested using a recent branch build): 1. Open http://www.xslf.com 2. choose one of the feeds from the feed menu button 3. notice that "Switch Page Direction" work on second access only. This is happening because the code in SwitchDocumentDirection relies on document.dir being either ltr or rtl: aWindow.document.dir = (aWindow.document.dir == "ltr" ? "rtl" : "ltr"); But document.dir seems to be an empty string before it is set manually. Note I've one semi-related change in my version of subscribe.xhtml - the <body> dir attribute is removed. related to bug 80352 (which is supposed to be fixed on the branch)?
Hrm, this is actually a regression, it's reproducible in other LTR pages as well (e.g. bmo) where it worked fine in 1.8.0.
Severity: normal → major
Summary: document.dir is "" in firefox's subscribe.xhtml unless it is set manually → regression: document.dir is "" unless it's set manually
Comment on attachment 222194 [details] [diff] [review] patch So who's the caller of SetBidi in this case?
GetUserPreferences from nsPresContext::Init On branch that codepath doesn't always has a presshell, so I was crashing, which is why I put in that test in the branch version of bug 80352
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.