Closed
Bug 337998
Opened 18 years ago
Closed 18 years ago
subscribe.xhtml shouldn't set the dir attribute on the body to the chrome direction
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)
Firefox Graveyard
RSS Discovery and Preview
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: asaf, Assigned: asaf)
Details
(Keywords: fixed1.8.1, intl)
Attachments
(1 file)
|
4.28 KB,
patch
|
mconnor
:
review+
asaf
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
from subscribe.xhtml: <body dir="&locale.dir;" This breaks: 1) Preview of ltr feeds in a RTL UI. 2) BiDi UI stuff (Context Menu->Switch Page Direction / View->Switch Page Direction). AFAICT there's no way to specify the direction for a feed; for now, we should just keep it in the default direction (which is LTR), users can use "Switch Page Direction" for rtl feeds.
|
Assignee | |
Comment 1•18 years ago
|
||
-> me, assuming beng and robert are OK with this change.
Assignee: nobody → bugs.mano
Flags: blocking-firefox2?
Priority: -- → P1
Target Milestone: --- → Firefox 2 beta1
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•18 years ago
|
||
There are still some minor issues (esp. with the float: left/right stuff which i've no idea how to fix :-/).
Attachment #222150 -
Flags: review?(mconnor)
Attachment #222150 -
Flags: approval-branch-1.8.1+
|
||
Updated•18 years ago
|
Attachment #222150 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
1.8 branch: mozilla/browser/themes/pinstripe/browser/feeds/subscribe.css 1.1.2.7 mozilla/browser/themes/winstripe/browser/feeds/subscribe.css 1.1.2.7 mozilla/browser/components/feeds/content/subscribe.xhtml 1.1.2.6 trunk: mozilla/browser/themes/pinstripe/browser/feeds/subscribe.css 1.8 mozilla/browser/themes/winstripe/browser/feeds/subscribe.css 1.8 mozilla/browser/components/feeds/content/subscribe.xhtml 1.7
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking-firefox2?
Keywords: fixed1.8.1
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•