Closed Bug 338168 Opened 18 years ago Closed 16 years ago

Undo in searchbox restores grey text as black

Categories

(Firefox :: Search, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 3 beta4

People

(Reporter: pamg.bugs, Assigned: dao)

References

Details

(Keywords: polish)

Click in searchbox, then choose "Undo" from menu without changing focus.  "Google Search" (or whichever engine you have selected) appears in selected black text in the searchbar.
See also bug 324354. Maybe we can just clear the undo buffer on focus, if the search bar is empty? You wouldn't be able to "undo" to an older query, but if the search bar is empty you probably don't want to. I doubt people use "undo" much in the search bar, since queries are usually short and can be easily retyped, and auto complete history remembers the ones you actually used (or will once some combination of bug 337491 and bug 338061 is fixed, for the Suggest-enabled plugins).
Right now I'm trying to figure out a way to set/remove the gray text without creating an undoable transaction...
This happans in "Places" window also, so maybe the component shouldn't be "Search"?
Blocks: 335435
Assignee: nobody → joe
Flags: blocking-firefox2?
Whiteboard: swag:2d
Target Milestone: --- → Firefox 2 beta1
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Whiteboard: swag:2d → swag:2d [at risk]
This is a polish bug, not harmful to users, not going to hold on this.
Flags: blocking-firefox2+ → blocking-firefox2-
Also look at bug # 394790 
Assignee: mozilla → nobody
Whiteboard: swag:2d [at risk]
Target Milestone: Firefox 2 beta2 → ---
Version: 2.0 Branch → Trunk
Assignee: nobody → dao
Depends on: 406095
Bug 400844 is going to make the search box use the new emptyText property, which should solve this problem.  Marking this dependent on bug 400844.
Depends on: 400844
Bug 400844 is about the Places Library.
No longer depends on: 400844
(In reply to comment #6)
> Bug 400844 is going to make the search box use the new emptyText property,
> which should solve this problem.  Marking this dependent on bug 400844.
(In reply to comment #7)
> Bug 400844 is about the Places Library.

Oops, wrong bug :-/ It was supposed to go to bug 407317...
I think we can close this. Bug 406095 contains a fix that seems to work.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.