338168 - Undo in searchbox restores grey text as black

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Pam Greene]

Click in searchbox, then choose "Undo" from menu without changing focus.  "Google Search" (or whichever engine you have selected) appears in selected black text in the searchbar.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

See also bug 324354. Maybe we can just clear the undo buffer on focus, if the search bar is empty? You wouldn't be able to "undo" to an older query, but if the search bar is empty you probably don't want to. I doubt people use "undo" much in the search bar, since queries are usually short and can be easily retyped, and auto complete history remembers the ones you actually used (or will once some combination of bug 337491 and bug 338061 is fixed, for the Suggest-enabled plugins).

Comment 2

[Joe Hughes]

Right now I'm trying to figure out a way to set/remove the gray text without creating an undoable transaction...

Comment 3

[Niro]

This happans in "Places" window also, so maybe the component shouldn't be "Search"?

Comment 4

[Mike Connor [:mconnor]]

This is a polish bug, not harmful to users, not going to hold on this.

Comment 5

[Dhruv Ahuja]

Also look at bug # 394790 

Comment 6

[(no longer active)]

Bug 400844 is going to make the search box use the new emptyText property, which should solve this problem.  Marking this dependent on bug 400844.

Comment 7

[Dão Gottwald [:dao]]

Bug 400844 is about the Places Library.

Comment 8

[(no longer active)]

(In reply to comment #6)
> Bug 400844 is going to make the search box use the new emptyText property,
> which should solve this problem.  Marking this dependent on bug 400844.
(In reply to comment #7)
> Bug 400844 is about the Places Library.

Oops, wrong bug :-/ It was supposed to go to bug 407317...

Comment 9

[Dão Gottwald [:dao]]

I think we can close this. Bug 406095 contains a fix that seems to work.