400844 - Label in organizer's search field becomes search text in some non-default modes (black, query)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a9pre) Gecko/2007102304 Minefield/3.0a9pre

Steps to reproduce:
1. Go to the URL, or open Bookmarks → Organize Bookmarks. The search field caption “Search in 'Bookmarks'” is gray.
2. Type something in the bookmarks search field. The caption disappears immediately upon clicking the field.
3. Press the “Selected Folder”, “Bookmarks Menu”, or “Bookmarks Toolbar” mode button.
4. Press the [X] button to clear the search field.

Actual results:
The caption returns, but it is black and does not disappear, so may be used as a search query. If selected and deleted, it returns in a moment, unless something takes its place.

Expected results:
The caption is grayed out, and disappears upon clicking, not being obtrusive.
It works correctly when the Advanced search mode is “All Bookmarks” or “History”.

Comment 1

[Mike Connor [:mconnor]]

I should just write the emptytext attr patch today.

blocking. M10.

Comment 2

[Michael Schonfeld]

Attachment: v1

Comment 3

[Asaf Romano (gone)]

Comment on attachment 300468 [details] [diff] [review]
v1

I would rather wait for bug 406095 to land first and fix this using the emptyText property afterwards.

Comment 4

[Dão Gottwald [:dao]]

Attachment: use emptyText

note that I removed |<method name="onFocus">...this.select();| in favor of clickSelectsAll="true".

Comment 5

[Dão Gottwald [:dao]]

Attachment: use emptyText v2

Where the "reset" event is dispatched, the code tries to track whether the event should be canceled, which doesn't do anything eventually. Can we just remove this?

Comment 6

[Asaf Romano (gone)]

What's the toolkit/ change about?

Comment 7

[Dão Gottwald [:dao]]

It fixes an issue that I discovered when working on this bug. We shouldn't display the emptyText while the textbox has focus.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 301759 [details] [diff] [review]
use emptyText v2

OK, r=mano. Please file a bug on turning clickSelectsAll only if the pref is set.

Comment 9

[Dão Gottwald [:dao]]

We only have a clickSelectsAll pref for the Location Bar (browser.urlbar.clickSelectsAll).

Comment 10

[Asaf Romano (gone)]

It's also supported by the search bar, and i think we should use it here too.

Comment 11

[Reed Loden [:reed]]

Checking in toolkit/content/widgets/textbox.xml;
/cvsroot/mozilla/toolkit/content/widgets/textbox.xml,v  <--  textbox.xml
new revision: 1.53; previous revision: 1.52
done
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.125; previous revision: 1.124
done
Checking in browser/components/places/content/places.xml;
/cvsroot/mozilla/browser/components/places/content/places.xml,v  <--  places.xml
new revision: 1.29; previous revision: 1.28
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.104; previous revision: 1.103
done
Checking in browser/themes/gnomestripe/browser/places/organizer.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/organizer.css,v  <--  organizer.css
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/pinstripe/browser/places/organizer.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/organizer.css,v  <--  organizer.css
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/winstripe/browser/places/organizer.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/organizer.css,v  <--  organizer.css
new revision: 1.2; previous revision: 1.1
done

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0 ID:2008061004

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv