338188 - tabs are misaligned

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060516 Minefield/3.0a1 ID:2006051609 [cairo]

go to url and look at the tabs (screenshot follows)

regressionwindow

works in 20060516 0809pst build
fails in 20060516 1053pst cairo build

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20060516+0730&maxdate=20060516+1051&cvsroot=%2Fcvsroot

looks like Bug 335913

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Comment 2

[Dão Gottwald [:dao]]

Attachment: another screenshot

from http://www.0xdeadbeef.com/weblog/
maybe the same issue, or at least caused by the same bug.

Comment 3

[Dão Gottwald [:dao]]

I'm not sure, because I cannot compare to 20060516 1053pst, but Acid2 looks screwed up, too.

Comment 4

[Peter van der Woude [:Peter6]]

Attachment: screenshot ACID2 before/after

http://www.webstandards.org/files/acid2/test.html#top

Comment 5

[Dão Gottwald [:dao]]

right, I meant 0809pst ...
anyway, regarding acid2, that's this rule:

.picture { background: red; } /* overriden by preferred stylesheet below */

should be overriden by:

<link rel="appendix stylesheet" href="data:text/css,.picture%20%7B%20background%3A%20none%3B%20%7D"> <!-- this stylesheet should be applied by default -->

Comment 6

[Boris Zbarsky [:bzbarsky]]

Is there a minimal-ish testcase?  Is the NodeIsBefore() call in the CSSLoader lying?

Comment 7

[Alex Vincent [:WeirdAl]]

bz suspected CSSParser could be at fault.  I just filed bug 338247 for a
compile-time warning, on code which CSSParser does use.  Connection?

Comment 8

[Alex Vincent [:WeirdAl]]

Updating URL to reflect testcase provided by bz.

Comment 9

[Boris Zbarsky [:bzbarsky]]

OK, so this is caused by a logic error in PositionIsBefore().  See bug 338247

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Could someone test if this has been fixed now that bug 338247 has been?

Comment 11

[Alex Vincent [:WeirdAl]]

Yep, that did it.  Marking FIXED.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

For me too, using build 2006-05-17-03; verified FIXED, thanks!