338247 - m:\builds\vc8debug\dist\include\content\nsContentUtils.h(220) : warning C4554: '&' : check operator precedence for possible error; use parentheses to clarify precedence

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alex Vincent [:WeirdAl]]

/**
   * Returns true if aNode1 is before aNode2 in the same connected
   * tree.
   */
  static PRBool PositionIsBefore(nsINode* aNode1,
                                 nsINode* aNode2)
  {
    return ComparePosition(aNode1, aNode2) &
      (nsIDOM3Node::DOCUMENT_POSITION_PRECEDING |
       nsIDOM3Node::DOCUMENT_POSITION_DISCONNECTED) ==
      nsIDOM3Node::DOCUMENT_POSITION_PRECEDING;
  }

Building SeaMonkey trunk on WinXP, MSVC8 keeps spewing this build warning.

Comment 1

[Alex Vincent [:WeirdAl]]

bz suspected CSSParser could be at fault.  I just filed bug 338247 for a
compile-time warning, on code which CSSParser does use.  Connection?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

sicking, please land this after you review it?  I won't be able to till May 29...

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 222309 [details] [diff] [review]
Fix

Thanks. I was just about to attach the exact same patch

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in. Thanks for findeing this Alex