338432 - Sunbird on trunk doesn't need xpcom/obsolete

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Matthew (lilmatt) Willis]

I've searched calendar's code for uses of the contents of xpcom/obsolete. (nsFile, nsFileStream, nsSpecialSystemDirectory, etc.)

We're not using any.

I've successfully built and tested Sunbird with "--disable-xpcom-obsolete" in my mozconfig.

Now it's time to make this change in /mozilla/configure.in

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - disables including xpcom/obsolete by default

Comment 2

[Joey Minta]

Comment on attachment 222496 [details] [diff] [review]
rev0 - disables including xpcom/obsolete by default

r=jminta

Comment 3

[Matthew (lilmatt) Willis]

Attachment: additional patch so we don't break ye olde installer

Comment 4

[Benjamin Smedberg]

Comment on attachment 222496 [details] [diff] [review]
rev0 - disables including xpcom/obsolete by default

At this point it might make sense to set the default value to 1, and override for tbird/seamonkey.

Comment 5

[Matthew (lilmatt) Willis]

(In reply to comment #4)
> At this point it might make sense to set the default value to 1, and override
> for tbird/seamonkey.

bsmedberg:
I'm reluctant to do that myself, given the wide variety of stuff that could be broken by such a change. :)

Oh, and I forgot to r? branch-1.8.1

Comment 6

[Matthew (lilmatt) Willis]

Patches checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 7

[Stefan Sitter [:ssitter]]

configure: error: Building without xpcom-obsolete isn't support when building xpinstal.

Building Sunbird from MOZILLA_1_8_BRANCH fails because xpinstall still requires xpcom-obsolete. See also Bug 320210 Comment #6 and following.

So either the patch to mozilla/configure.in should be backed out from branch or "ac_add_options --enable-xpcom-obsolete" has to be added to Sunbirds branch makefile.

Comment 8

[Matthew (lilmatt) Willis]

Didn't see this until I tried building on Win32 for some reason.
Backed out ONLY on branch.

-> FIXED