Closed Bug 338432 Opened 14 years ago Closed 14 years ago

Sunbird on trunk doesn't need xpcom/obsolete

Categories

(Calendar :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

Attachments

(2 files)

I've searched calendar's code for uses of the contents of xpcom/obsolete. (nsFile, nsFileStream, nsSpecialSystemDirectory, etc.)

We're not using any.

I've successfully built and tested Sunbird with "--disable-xpcom-obsolete" in my mozconfig.

Now it's time to make this change in /mozilla/configure.in
Attachment #222496 - Flags: second-review?(benjamin)
Attachment #222496 - Flags: first-review?(jminta)
Comment on attachment 222496 [details] [diff] [review]
rev0 - disables including xpcom/obsolete by default

r=jminta
Attachment #222496 - Flags: first-review?(jminta) → first-review+
Attachment #222540 - Flags: first-review?(jminta) → first-review+
Comment on attachment 222496 [details] [diff] [review]
rev0 - disables including xpcom/obsolete by default

At this point it might make sense to set the default value to 1, and override for tbird/seamonkey.
Attachment #222496 - Flags: second-review?(benjamin) → second-review+
Attachment #222496 - Flags: approval-branch-1.8.1?(benjamin)
(In reply to comment #4)
> At this point it might make sense to set the default value to 1, and override
> for tbird/seamonkey.

bsmedberg:
I'm reluctant to do that myself, given the wide variety of stuff that could be broken by such a change. :)

Oh, and I forgot to r? branch-1.8.1



Status: NEW → ASSIGNED
Attachment #222496 - Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
Patches checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
configure: error: Building without xpcom-obsolete isn't support when building xpinstal.

Building Sunbird from MOZILLA_1_8_BRANCH fails because xpinstall still requires xpcom-obsolete. See also Bug 320210 Comment #6 and following.

So either the patch to mozilla/configure.in should be backed out from branch or "ac_add_options --enable-xpcom-obsolete" has to be added to Sunbirds branch makefile.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Didn't see this until I tried building on Win32 for some reason.
Backed out ONLY on branch.

-> FIXED
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Summary: Sunbird doesn't need xpcom/obsolete → Sunbird on trunk doesn't need xpcom/obsolete
You need to log in before you can comment on or make changes to this bug.