338541 - All prefwindows are blank/broken and feeds are empty.

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[hhh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1

Between the May 18th and May 19th builds, Add-ons is broken. The manager's main content is blank when you open it, and clicking the Themes icon has no effect.

Reproducible: Always

Steps to Reproduce:
1.Tools> Add-ons
2.Ta da!
3.

Actual Results:  
Nothing

Expected Results:  
Something

Js Console error...
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mozapps/content/extensions/extensions.js :: Shutdown :: line 487"  data: no]

http://forums.mozillazine.org/viewtopic.php?p=2271877#2271877

Comment 1

[Régis Caspar]

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1 ID:2006051905 [cairo]

 -> severity : major

Comment 2

[Ria Klaassen (not reading all bugmail)]

This happened between 1.9a1_2006051901 and 1.9a1_2006051903.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Oh well, I really did not change the component :(

Comment 4

[hhh]

(In reply to comment #3)
> Oh well, I really did not change the component :(
> 

I did, it seems this is affecting all prefwindows.

Comment 5

[Ria Klaassen (not reading all bugmail)]

Checkins: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-05-19+00%3A00&maxdate=2006-05-19+03%3A00

Comment 6

[Ria Klaassen (not reading all bugmail)]

And most of my feeds are empty.
Not sure to what component this all belongs.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Does this work now that some of those checkins have been backed out?

Comment 8

[Peter van der Woude [:Peter6]]

(In reply to comment #7)
> Does this work now that some of those checkins have been backed out?
> 

Yeah, same result with the backouts included

Comment 9

[tabmix.onemen]

the bug that caused
https://bugzilla.mozilla.org/show_bug.cgi?id=338541 is in
radio.xml in _getRadioChildren methode , its look like that the createTreeWalker is broken there. if i changed

- var iterator = this.ownerDocument.createTreeWalker(this, NodeFilter.SHOW_ELEMENT, this._filterRadioGroup, true);
- while (iterator.nextNode())
-   radioChildren.push(iterator.currentNode);

+ var XULNS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
+ var _radioChildren = this.getElementsByTagNameNS(XULNS, "radio");
+ for (var i; i< _radioChildren.length; i++)
+   radioChildren.push(_radioChildren[i]);

then all work well, but i don't know if this patch is valid because the remark in getRadioChildren

Comment 10

[Peter van der Woude [:Peter6]]

bug 337543 Gavin ?

works in firefox-3.0a1.en-US.win32_20060519_0149pst_cairo.zip
fails in firefox-3.0a1.en-US.win32_20060519_0402pst_cairo.zip

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> bug 337543 Gavin ?

Yes, that seems likely.

Comment 12

[Ria Klaassen (not reading all bugmail)]

Weird in that case that a build with the ID 1.9a1_2006051903 contains patches checked in on 2006-05-19 03:01.

Comment 13

[hhh]

The UI for file download options is affected by this as well...
http://forums.mozillazine.org/viewtopic.php?p=2272092#2272092

Comment 14

[Peter van der Woude [:Peter6]]

can someone create a testcase for this bug please ?

Comment 15

[Ria Klaassen (not reading all bugmail)]

Firefox is one big testcase at the moment :) :)
Thought that Onemen had a patch, no?

Comment 16

[Peter van der Woude [:Peter6]]

Open Options
Error: children[i] has no properties
Source file: chrome://global/content/bindings/radio.xml
Line: 113

Error: children[i] has no properties
Source file: chrome://global/content/bindings/radio.xml
Line: 45

Error: children[i] has no properties
Source file: chrome://global/content/bindings/radio.xml
Line: 148

Open Add-ons manager
Error: children[i] has no properties
Source file: chrome://global/content/bindings/radio.xml
Line: 113

Close add-ons manager
Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]
Source file: chrome://mozapps/content/extensions/extensions.js
Line: 487

Comment 17

[Alex Vincent [:WeirdAl]]

Attachment: minimal testcase

Comment 18

[Alex Vincent [:WeirdAl]]

The testcase I just attached shows the treewalker's setting of currentNode is broken completely.  It works in Firefox 1.5.0.3.

Comment 19

[Alex Vincent [:WeirdAl]]

Attachment: minimal testcase (fixed)

Whoops.  Syntax error.

Comment 20

[Ria Klaassen (not reading all bugmail)]

What I also see is that the contents of the JSConsole disappear when I hover over the icons and move my mouse outside the window. When I restart Firefox it stays away for some time and then it begins again.

Comment 21

[Ria Klaassen (not reading all bugmail)]

Also: when the Console is full of errors and I close it and reopen it after a while, it is suddenly empty or most of them are gone.

Comment 22

[Alex Vincent [:WeirdAl]]

So, GetCurrentNode says CallQueryInterface(mCurrentNode, aCurrentNode), but doesn't return right away.  The next thing that happens is aCurrentNode is set to null.  Whoops.

Patch coming up, as soon as I verify that this indeed is the cause of the bustage.

Comment 23

[Alex Vincent [:WeirdAl]]

Attachment: patch

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/base/src/nsTreeWalker.cpp;
/cvsroot/mozilla/content/base/src/nsTreeWalker.cpp,v  <--  nsTreeWalker.cpp
new revision: 1.18; previous revision: 1.17
done

Comment 25

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1 ID:2006051913

Verified

jsconsole remains empty (no errors/warnings)
Options window  OK
Add-ons manager OK
Live Bookmarks  OK

Comment 26

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Thanks for the fix Alex!

Comment 27

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2006-05-20-04 of SeaMonkey trunk under Windows XP.

Comment 28

[Andrew Schultz]

*** Bug 339401 has been marked as a duplicate of this bug. ***

Comment 29

[Robert Sayre]

added to mochitest

RCS file: /cvsroot/mozilla/testing/mochitest/tests/test_bug338541.xhtml,v
done
Checking in tests/test_bug338541.xhtml;
/cvsroot/mozilla/testing/mochitest/tests/test_bug338541.xhtml,v  <--  test_bug338541.xhtml
initial revision: 1.1
done