338596 - SVG objectBoundingBox value seems ignored in patternUnits (Minefield as of May 19 '06)

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Thomas Wisniewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060519 Minefield/3.0a1

When creating an SVG pattern, objectBoundingBox units do not seem to apply to the patternUnits property, only patternContentUnits. It is my understanding that the coordinates of the pattern's document fragment should be changed such that (0,0) in the minimum x,y pair of the bounding box around the element referencing the pattern (http://www.w3.org/TR/1999/WD-SVG-19991203/pservers.html#PatternUnitsAttribute - link is a little outdated, but spells things out a little better than the SVG 1.1 documentation about this property+value)

Reproducible: Always

Steps to Reproduce:
1. View SVG document given in "additional details" in Minefield.
2.
3.

Actual Results:  
Red rect in test case under "additional details" seems to tile from top/left corner of viewport.

Expected Results:  
Red rect ought to tile from top/left corner of black-outlined region, occupying the top quarter of outlined region.

<?xml version="1.0" ?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
	<defs>
		<pattern id="test" patternUnits="objectBoundingBox" patternContentUnits="objectBoundingBox">
			<rect x="0" y="0" width="0.5" height="0.5" fill="red" />
		</pattern>
	</defs>

	<rect x="20" y="20" width="200" height="200" fill="url(#test)" stroke="black" />
</svg>

Comment 1

[Robert Longson [:longsonr]]

Attachment: don't ignore pattern content translation

FWIW with this patch example now displays the same in Adobe SVG viewer

Comment 2

[Robert Longson [:longsonr]]

Checked in.

Checking in nsSVGPatternFrame.cpp;
/cvsroot/mozilla/layout/svg/base/src/nsSVGPatternFrame.cpp,v  <--  nsSVGPatternFrame.cpp
new revision: 1.25; previous revision: 1.24
done

Comment 3

[Robert Longson [:longsonr]]

Checked in pattern reftest:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01a.svg

Comment 4

[Robert Longson [:longsonr]]

Attachment: reporters testcase