377263 - The percentage and fraction values relative to object bounding boxes do not work

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Jan]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a4pre) Gecko/20070402 Minefield/3.0a4pre
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a4pre) Gecko/2007040204 Minefield/3.0a4pre

The percentage and fraction values relative to object bounding boxes do not work

Reproducible: Always

Steps to Reproduce:
1. Open attached test page.

Actual Results:  
SVG image is rendered incorrectly, as is shown on attached screenshot.
In third row of testing picture the blank rectangles are displayed for
percentage and fraction values.


Expected Results:  
SVG image is rendered correctly - it match to the reference PNG image placed on
the right side of page.

Happens also on PC/Linux

Comment 1

[Jan]

Attachment: Test page (use URL field to open)

Comment 2

[Jan]

jar added to URL field.

Comment 3

[Robert Longson [:longsonr]]

Attachment: patch

I'm not absolutely sure this is right but it does make the testcase work.

Comment 4

[Robert Longson [:longsonr]]

Attachment: correct patch

previous patch only worked if scale was 1.

Comment 5

[Robert Longson [:longsonr]]

Attachment: third time lucky

This one also fixes bug 377399

Comment 6

[Robert Longson [:longsonr]]

Attachment: works better if all files included

apologies for all the required attempts.

Comment 7

[tor]

Comment on attachment 261677 [details] [diff] [review]
works better if all files included

>@@ -637,23 +637,21 @@ nsSVGPatternFrame::ConstructCTM(nsIDOMSV
...
>+    float width,height;

Nit: add space.

> nsSVGPatternFrame::GetPatternMatrix(nsIDOMSVGMatrix **aCTM, 
>                                     nsIDOMSVGRect *bbox,
>+                                    nsIDOMSVGRect *callerBBox,
>                                     nsIDOMSVGMatrix *callerCTM)
> {
...
>+  if (type == nsIDOMSVGPatternElement::SVG_PUNITS_OBJECTBOUNDINGBOX) {
>+    float x,y;

Ditto.

>@@ -756,25 +764,28 @@ nsSVGPatternFrame::GetCallerGeometry(nsI
...
>-    float x,y,width,height,xscale,yscale;
>+    float x,y,width,height;

Ditto.

>+    float xpos,ypos,xscale,yscale;

Ditto.

>+    x = (x - xpos) / xscale;
>+    y = (y - ypos)/ yscale;

Ditto.

Comment 8

[Robert Longson [:longsonr]]

Attachment: address review comments

Comment 9

[Robert Longson [:longsonr]]

checked in.

Comment 10

[Robert Longson [:longsonr]]

Checked in reftests:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01a.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01b.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/objectBoundingBox-and-pattern-01c.svg