338728 - Don't dispatch native events after [NSApplication terminate:] is called

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mark Mentovai]

Forking from bug 338249.  Native events should not be dispatched after [NSApplication terminate:] is called.  This affects applications that embed Gecko and expect native event processing to stop after calling [NSApp terminate:].  Bug 338249 comment 0 and bug 338249 comment 10 contain representative console output that Camino produces when it's asked to quit (or, as in that bug, when it quits spontaneously).

There is a patch in bug 338249, attachment 222334 [details] [diff] [review].

Comment 1

[Mark Mentovai]

Attachment: Patch

This is the command-Q patch from bug 338249 (attachment 222334 [details] [diff] [review]) brought up to date, but I'm not sure it's exactly the right thing to do.  When someone calls [NSApplication terminate:], we want to discontinue processing native events for sure, but an early return from ProcessNextNativeEvent like this will cause the nsBaseAppShell to spin a really quick loop without any blocking - blocking is ordinarily handled by calling ProcessNextNativeEvent(PR_TRUE).

On top of that, this doesn't clean up all of the autoreleased-to-no-pool messages I see when quitting Camino.

Comment 2

[Mark Mentovai]

It seems like this isn't necessary with the patch in bug 339371.

Comment 3

[Chris Lawson (gone)]

*** Bug 340467 has been marked as a duplicate of this bug. ***

Comment 4

[Mark Mentovai]

OK, fine, maybe it is necessary.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Talkback for recent trunk builds is still showing this, too.  My own builds have stopped crashing on quit, so the other bug seems to have helped but apparently didn't get everything.

Comment 6

[Mark Mentovai]

Attachment: Up-to-date

Comment 7

[Mark Mentovai]

Comment on attachment 224813 [details] [diff] [review]
Up-to-date

kreeger points out that we can add the observer with object:nil.

Comment 8

[Chris Lawson (gone)]

*** Bug 341129 has been marked as a duplicate of this bug. ***

Comment 9

[Mark Mentovai]

*** Bug 341129 has been marked as a duplicate of this bug. ***

Comment 10

[ntnv9203]

How do you install the patches?

Comment 11

[Mark Mentovai]

Checked in on trunk.