338754 - Safebrowsing does not work (components aren't in the installer manifest)

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[u88484]

Tested on latest trunk builds safebrowsing does not work. No notification with the ballon or an icon in the locationbar. Regis on mozillaine forums created a debug build and says that these files are missing. http://caspar.regis.free.fr/various/components.zip

Comment 1

[u88484]

This is also seen in the javascript console on each new windows created which the files in regis's zip also fixes.

Warning: reference to undefined property Cc['@mozilla.org/safebrowsing/application;1']
Source file: chrome://browser/content/safebrowsing/sb-loader.js
Line: 57
 ----------
Error: Cc['@mozilla.org/safebrowsing/application;1'] has no properties
Source file: chrome://browser/content/safebrowsing/sb-loader.js
Line: 57 

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This file is a mess, I think it would make more sense to sort by component instead of alphabetically.

Comment 3

[u88484]

Doesn't work in zip builds either.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 338757 has been marked as a duplicate of this bug. ***

Comment 5

[Darin Fisher]

Comment on attachment 222815 [details] [diff] [review]
patch

Thanks Gavin!

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checked in, 1.8 branch and trunk.
mozilla/browser/installer/windows/packages-static 	1.53.2.24
mozilla/browser/installer/unix/packages-static 	1.50.2.23
mozilla/browser/installer/unix/packages-static 	1.72
mozilla/browser/installer/windows/packages-static 	1.77