Closed
Bug 338754
Opened 18 years ago
Closed 18 years ago
Safebrowsing does not work (components aren't in the installer manifest)
Categories
(Toolkit :: Safe Browsing, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2 alpha3
People
(Reporter: u88484, Assigned: Gavin)
References
()
Details
(Keywords: verified1.8.1)
Attachments
(1 file)
|
2.23 KB,
patch
|
darin.moz
:
review+
darin.moz
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Tested on latest trunk builds safebrowsing does not work. No notification with the ballon or an icon in the locationbar. Regis on mozillaine forums created a debug build and says that these files are missing. http://caspar.regis.free.fr/various/components.zip
This is also seen in the javascript console on each new windows created which the files in regis's zip also fixes. Warning: reference to undefined property Cc['@mozilla.org/safebrowsing/application;1'] Source file: chrome://browser/content/safebrowsing/sb-loader.js Line: 57 ---------- Error: Cc['@mozilla.org/safebrowsing/application;1'] has no properties Source file: chrome://browser/content/safebrowsing/sb-loader.js Line: 57
|
Assignee | |
Comment 2•18 years ago
|
||
This file is a mess, I think it would make more sense to sort by component instead of alphabetically.
|
|
Assignee | |
Updated•18 years ago
|
Summary: Safebrowsing does not work on windows builds → Safebrowsing does not work in installer builds
|
|
Assignee | |
Updated•18 years ago
|
Attachment #222815 -
Flags: approval-branch-1.8.1?(darin)
Doesn't work in zip builds either.
Summary: Safebrowsing does not work in installer builds → Safebrowsing does not work in windows builds
|
|
Assignee | |
Comment 4•18 years ago
|
||
*** Bug 338757 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Updated•18 years ago
|
Summary: Safebrowsing does not work in windows builds → Safebrowsing does not work (components aren't in the installer manifest)
|
||
Comment 5•18 years ago
|
||
Comment on attachment 222815 [details] [diff] [review] patch Thanks Gavin!
Attachment #222815 -
Flags: review?(darin)
Attachment #222815 -
Flags: review+
Attachment #222815 -
Flags: approval-branch-1.8.1?(darin)
Attachment #222815 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Checked in, 1.8 branch and trunk. mozilla/browser/installer/windows/packages-static 1.53.2.24 mozilla/browser/installer/unix/packages-static 1.50.2.23 mozilla/browser/installer/unix/packages-static 1.72 mozilla/browser/installer/windows/packages-static 1.77
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 2 alpha3
Version: unspecified → 2.0 Branch
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1
|
|
Assignee | |
Updated•18 years ago
|
Keywords: fixed1.8.1
|
||
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•