338772 - Show can't-drop indicator when dragging PTF bookmarks such that they won't move when dropped

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Right now, if you drag a tab a short distance, so that it won't actually change position when you drop, you get the can't-drop indicator.  Bookmarks on the personal toolbar folder don't currently do that, and probably should.

http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksMenu.js#470

<jag> On bookmark D&D: http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksMenu.js#185
<jag> You should be able to call that method from canDrop and if it returns DROP_BEFORE or DROP_AFTER and it's for your next/prevSibling, you can return false

"your" is aDragSession.sourceNode (or something based on it)

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Inlining this into the existing return would make it ridiculously long.

Comment 2

[jag (Peter Annema)]

Comment on attachment 233429 [details] [diff] [review]
patch

Instead of that comment you could move the second part to a |acceptsBookmarks(aTarget)| function which onDragStart could then call.

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Fixed on trunk with the patch as attached.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Fixed on branch