354140 - In <bookmarksMenu.js>, "Error: aDragSession.sourceNode has no properties"

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/20060919 SeaMonkey/1.1b] (nightly) (W98SE)

When hovering a file (from Windows Explorer) over the top menu/bars...
[
Error: aDragSession.sourceNode has no properties
Source File: chrome://communicator/content/bookmarks/bookmarksMenu.js
Line: 480
]

Code is
[
  canDrop: function (aEvent, aDragSession)
  {
    var target = aEvent.target;

    if (aDragSession) { // this function gets its API abused by onDragStart
      var orientation = BookmarksMenu.getBTOrientation(aEvent, target);
      if (target == aDragSession.sourceNode ||
          (target == aDragSession.sourceNode.previousSibling &&     // Line: 480
           orientation == BookmarksUtils.DROP_AFTER) ||
          (target == aDragSession.sourceNode.nextSibling &&
           orientation == BookmarksUtils.DROP_BEFORE))
        return false;
    }
]

I seems the |if| should start with a
[
aDragSession.sourceNode
]
test, similar to the
[
    if (this.isTimerSupported || !aDragSession.sourceNode) {
]
which are elsewhere.


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/2006091703 BonEcho/2.0] (nightly) (W98SE)

(Does not have this bug.)

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Serge, have you considered setting up your own build environment?  Your analyses of my recent regressions (oops ;)) have been pretty good, and it would be great to have another SeaMonkey developer.

I'll try to take care of this today.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Serge, have you considered setting up your own build environment?  Your

Build: yes, but I have yet(!) to upgrade my home computer+OS to something much more recent. (That should happen, eventually.)

NB: As in I'd like to be able to use Trunk builds again, someday ;->

> analyses of my recent regressions (oops ;)) have been pretty good, and it would
> be great to have another SeaMonkey developer.

(Filing/etc bugs is the "only" part in which I am still "active" for the time being.)

> I'll try to take care of this today.

(This (JS) one I could have done, but I preferred to let you know...)

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Not requesting SR only because I don't think I need it.  Please superreview as well if you think it's required.  If it's r+, please also grant a= since I broke branch too :)

Comment 4

[[e-mail]]

Comment on attachment 240084 [details] [diff] [review]
patch

>     if (aDragSession) { // this function gets its API abused by onDragStart
>       var orientation = BookmarksMenu.getBTOrientation(aEvent, target);
>-      if (target == aDragSession.sourceNode ||
>+      if (aDragSession.sourceNode && (target == aDragSession.sourceNode ||
There's no point computing the orientation if we have no source node...

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch v2

Comment 6

[[e-mail]]

Comment on attachment 240783 [details] [diff] [review]
patch v2

r+sr=me

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 240783 [details] [diff] [review]
patch v2

Regression fix.

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/20061002 SeaMonkey/1.1b] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.