The default bug view has changed. See this FAQ.

isXPCOMJavaProxy throws NullPointerException

RESOLVED FIXED

Status

Core Graveyard
Java to XPCOM Bridge
RESOLVED FIXED
11 years ago
3 years ago

People

(Reporter: jhp (no longer active), Assigned: jhp (no longer active))

Tracking

({fixed1.8.0.5, fixed1.8.1})

Trunk
fixed1.8.0.5, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

929 bytes, patch
Adam L. Peller
: review+
jhp (no longer active)
: approval-branch-1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
If XPCOMJavaProxy.isXPCOMJavaProxy() is passed a null reference, than it will throw a NullPointerException.  Need to check for null ref and return false.
(Assignee)

Comment 1

11 years ago
Created attachment 222957 [details] [diff] [review]
patch
(Assignee)

Comment 2

11 years ago
Adam, you probably don't have permissions to set the review flags on a patch, but if you could take a look and give me your blessing (or not), I would appreciate that.

Updated

11 years ago
Attachment #222957 - Flags: review+
(Assignee)

Comment 3

11 years ago
Checked in to trunk and 1.8 branch. ->FIXED

Also asking for 1.8.0.5 approval.  This is a very minor, low-risk path to add a null check.
Flags: blocking1.8.0.5?
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Flags: blocking1.8.0.5?
(Assignee)

Updated

11 years ago
Attachment #222957 - Flags: approval1.8.0.5?
Attachment #222957 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 4

11 years ago
Re: approval1.8.0.5? : this patch is JavaXPCOM/XULRunner only and will not affect Firefox/Thunderbird.
Comment on attachment 222957 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #222957 - Flags: approval1.8.0.5? → approval1.8.0.5+
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.5
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.