Closed Bug 338896 Opened 19 years ago Closed 19 years ago

isXPCOMJavaProxy throws NullPointerException

Categories

(Core Graveyard :: Java to XPCOM Bridge, defect)

Product:
Core Graveyard
Component:
Java to XPCOM Bridge
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jhpedemonte, Assigned: jhpedemonte)

Details

(Keywords: fixed1.8.0.5, fixed1.8.1)

Attachments

(1 file)

patch
929 bytes, patch
apeller
: review+
jhpedemonte
: approval-branch-1.8.1+
dveditz
: approval1.8.0.5+
Details | Diff | Splinter Review
If XPCOMJavaProxy.isXPCOMJavaProxy() is passed a null reference, than it will throw a NullPointerException. Need to check for null ref and return false.
Attached patch patch — — Splinter Review
Adam, you probably don't have permissions to set the review flags on a patch, but if you could take a look and give me your blessing (or not), I would appreciate that.
Attachment #222957 - Flags: review+
Checked in to trunk and 1.8 branch. ->FIXED Also asking for 1.8.0.5 approval. This is a very minor, low-risk path to add a null check.
Flags: blocking1.8.0.5?
Keywords: fixed1.8.1
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: blocking1.8.0.5?
Attachment #222957 - Flags: approval1.8.0.5?
Attachment #222957 - Flags: approval-branch-1.8.1+
Re: approval1.8.0.5? : this patch is JavaXPCOM/XULRunner only and will not affect Firefox/Thunderbird.
Comment on attachment 222957 [details] [diff] [review] patch approved for 1.8.0 branch, a=dveditz for drivers
Attachment #222957 - Flags: approval1.8.0.5? → approval1.8.0.5+
Keywords: fixed1.8.0.5
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: