339031 - DND of bookmarks in Places window crashes Minefield in ZETA [@ BRegion::~BRegion]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Jorge G. Mare (a.k.a. Koki)]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1

Any attempt to use drag-and-drop in the Places window crashes Minefield.

Reproducible: Always

Steps to Reproduce:
1. Add a bookmark.
2. Select Bookmarks > Organize Bookmarks... to open the Places window.
3. Click and drag the newly created bookmark.

Actual Results:  
FF crashes.

Expected Results:  
User should be able to move bookmarks by using drag-and-drop.


SC attachment follows.

Comment 1

[Jorge G. Mare (a.k.a. Koki)]

Attachment: Stack crawl

Comment 2

[Doug Shelton]

Similar problem happens with Drag'n'drop of messages in email or newsgroup window of Thunderbird under BeOS.

Comment 3

[Ian]

Might not be the same cause but it is related.

What I am seeing is that if I try and delete the default subscription (BBC) Minefield crashes.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060525 Minefield/3.0a1 ID:0000000000

Comment 4

[Doug Shelton]

Confirming behavior.  Same problem with DND of mail entries in BeOS Thunderbird builds.

Comment 5

[tqh]

Attachment: fixes the Crash, and simplifies code

This patch fixes the crash. Could someone tell me if DND in places are a bit off for us, or if it's supposed to behave the way it does with this fix?

Comment 6

[tqh]

Attachment: fixed formatting

Comment 7

[tqh]

Comment on attachment 225043 [details] [diff] [review]
fixed formatting

r?
I suggest we fix other DND-troubles in new bugs.

Comment 8

[Sergei Dolgov]

Comment on attachment 225043 [details] [diff] [review]
fixed formatting

r=sergei_d

Comment 9

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsDragService.cpp;
/cvsroot/mozilla/widget/src/beos/nsDragService.cpp,v  <--  nsDragService.cpp
new revision: 1.16; previous revision: 1.15
done 

Comment 10

[Doug Shelton]

Attachment: BeOS-only patch for 1.8.1 branch

This fix needs to be back-ported to the 1.8.1 branch.

Comment 11

[Doug Shelton]

(In reply to comment #10)
> Created an attachment (id=241962) [edit]
> BeOS-only patch for 1.8.1 branch
> 
> This fix needs to be back-ported to the 1.8.1 branch.  
> 
Note: there is no change to the patch code, only to formatting.  for some reason, the old patch would not apply cleanly to branch, so I applied manually and created then new diff posted above.

Comment 12

[Sergei Dolgov]

Comment on attachment 241962 [details] [diff] [review]
BeOS-only patch for 1.8.1 branch

Code is buggy, I fixed it later in separate bug, I think it is better to create here proper code instantly.
See
dragRect.Set( aX, aY, aWidth, aHeight) is wrong,
must be
dragRect.Set( aX, aY, aX + aWidth, aY + aHeight)

For exact reference look into current trunk code

Comment 13

[Doug Shelton]

Attachment: BeOS-only cumulative patch for 1.8.1 branch

This section of code taken verbatim from trunk version of beos/nsDragService.cpp.  Fixes this bug on branch; includes fixes not in earlier (denied) patch.

Comment 14

[Sergei Dolgov]

Comment on attachment 241973 [details] [diff] [review]
BeOS-only cumulative patch for 1.8.1 branch

Askin branch approval - quite critical. fixes crash at DnD. 
Pure BeOS patch in pure BeOS folder

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 241973 [details] [diff] [review]
BeOS-only cumulative patch for 1.8.1 branch

a=beltzner on behalf of drivers for 1.8.1 branch (NPOTB)

Comment 16

[Sergei Dolgov]

Checking in mozilla/widget/src/beos/nsDragService.cpp;
/cvsroot/mozilla/widget/src/beos/nsDragService.cpp,v  <--  nsDragService.cpp
new revision: 1.13.28.3; previous revision: 1.13.28.2
done