339099 - Integrate extensions/cookie and extensions/permissions into libxul

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

"cookie" and "permissions" are really toolkit-level services and should be in libxul.

Comment 1

[Benjamin Smedberg]

Attachment: With a MOZ_PERMISSIONS switch, rev. 1

Comment 2

[Darin Fisher]

I think these should eventually move into toolkit/, but for now this solution seems reasonable.

Comment 3

[Darin Fisher]

Comment on attachment 223173 [details] [diff] [review]
With a MOZ_PERMISSIONS switch, rev. 1

>Index: configure.in

> dnl ========================================================
>+dnl Permissions Backend
>+dnl ========================================================
>+MOZ_ARG_DISABLE_BOOL(permissions,
>+[  --disable-permissions   Disable permissions (popup and cookie blocking)],
>+    MOZ_PERMISSIONS=,
>+    MOZ_PERMISSIONS=1
>+)

This is more than just the permissions backend, right?  Maybe the
"Permissions System"

I wish we had a better name for this other than permissions.  Reading
"--disable-permissions" doesn't really tell me much about what it does.
That said, I can't think of anything better.


r=darin

Comment 4

[Benjamin Smedberg]

Fixed on trunk.

Comment 5

[Scott MacGregor]

I wonder if this caused Bug #339410 in Thunderbird. Remote images stopped displaying in builds from the 26th of May.

It looks like we are now building the permissions extension which we weren't building before as a result of this change. I think it is replacing Thunderbird's permission manager for remote content. I'll keep digging. 

Comment 6

[Scott MacGregor]

Indeed this build change is the cause. This new content policy manager from the permissions directory is getting the last say on whether a url should be loaded even if thunderbird's content policy manager allows the load.

Comment 7

[Darin Fisher]

If xulrunner is to carry this code (and that seems like a reasonable idea), then we need a pref to disable it.  That way tbird can set that pref appropriately.