Closed Bug 339410 Opened 19 years ago Closed 17 years ago

images not displayed inside message body (POP/IMAP/RSS)

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ChefChaudart, Assigned: mscott)

References

Details

(Keywords: regression)

Attachments

(1 file)

part of the fix
879 bytes, patch
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060526 Minefield/3.0a1 Build Identifier: version 3 alpha 1 (20060526) you just see the link. Either on preview pane, or in message itself. Reproducible: Always Steps to Reproduce: 1. Open a RSS message 2. no image, just the hyperlink 3.
I've also begun to see this behavior over the past few days; it's still here as of version 3 alpha 1 (20060528). I'm also on XP SP2. No extensions installed (other than Talkback). LastVersion=3.0a1_2006052805/1.9a1_2006052805 LastOSABI=WINNT_x86-msvc
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.9a1?
Keywords: regression
*** Bug 339620 has been marked as a duplicate of this bug. ***
> no image, just the hyperlink This is a pretty vague description. Do you mean there is no rendering of HTML at all, or that the <img> tags are not rendering? What does "just the hyperlink" mean -- is this a reference to the link that appears in the envelope panel (Website: header) or does it appear in the message pane?
(In reply to comment #3) > > no image, just the hyperlink > > This is a pretty vague description. Do you mean there is no rendering of HTML > at all, or that the <img> tags are not rendering? > > What does "just the hyperlink" mean -- is this a reference to the link that > appears in the envelope panel (Website: header) or does it appear in the > message pane? > The images aren't loaded (alt-text is shown instead), but the rest of the page renders just fine. It's like an email where Thunderbird has blocked remote images, except there's no button to unblock them.
should note I'm seeing this with a POP3 mail account as well,
Linux too (Thunderbird/3.0a1 ID:2006053004). Pretty easy to see, just try load any message with remote images.
OS: Windows XP → All
Summary: images not displayed inside RSS message body → images not displayed inside message body (POP/IMAP/RSS)
Depends on: 339099
This was caused by Bug 339099.
Severity: normal → critical
Flags: blocking1.9a1? → blocking1.9a1+
I don't know much about contentpolicy/permissions: are all permissions providers intersected to find the final permissions?
if some content policy impl vetos the load, then the load doesn't happen.
Do we know why the extensions/permissions content policy is vetoing the load? Adding a pref is probably trivial, but I'd like to understand what's going on.
> Do we know why the extensions/permissions content policy is vetoing the load? I don't, offhand. It just talks to the permissions manager, right? Someone should step through and see what's going on...
permissions.default.image is set to 2 (reject) as a user pref (not a default pref) for many of us Thunderbird users. The new permission manager that is now part of the build is reading that pref and denying the image even though the application specific permission manager allows the load. I'm not sure where that setting came from, we don't set it anywhere in the UI. Maybe it was migrated over from the suite profiles. But so many of us are seeing this issue, I think it came from somewhere else.
I tried to reset "permissions.default.image to "1" and everything workes fine. But everytime I restart thunderbird, it is automatically set back to "2".
It looks like all-thunderbird.js has a pref that has since been removed from the tree but not from thunderbird: network.image.imageBehavior http://lxr.mozilla.org/mozilla/source/mail/app/profile/all-thunderbird.js#233 The newly built permissions manager migrates this pref to a user pref for permissions.default.images with a value of 2 (deny). http://lxr.mozilla.org/mozilla/source/extensions/permissions/nsContentBlocker.cpp#94 That explains why all Thunderbird users are seeing this.
Attached patch part of the fix — — Splinter Review
This patch fixes it for users who haven't already been updated to a build that builds the permission manager in \extensions. If you've already run that build, then permissions.default.images already has a value of 2 in your profile, you still won't see images.
In case it's not clear from comment 15: if you're seeing this behavior, you can implement that patch yourself to fix the problem: - edit <programdir>\pref\thunderbird-all.js find and delete this line: pref("network.image.imageBehavior", 2); add this line: pref("mail.folder.views.version", 0); - edit prefs.js (either edit the file, or use the config editor) change the value of permissions.default.image -- assuming this pref behaves as the other, similar prefs: '0' means "accept all" '1' means "accept from original server"
There must be another problem: with todays version Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060603 Thunderbird/3.0a1 ID:2006060306 some imap or pop-mails a displayed correctly, some not (with "permissions.default.image set to "1" or "0"). For an example an amazon-advertising mail from 25.5. ist displayed with images, the next amazon mail from 1.6. is only displayed without images. RSS-Feeds are all displayed correctly independently from the date.
(In reply to comment #16) > implement that patch yourself to fix the problem: > - edit <programdir>\pref\thunderbird-all.js I have neither a "pref" directory, nor a "thunderbird-all.js" file. :-\ Thunderbird version 3 alpha 1 (20060603) Windows (trunk nightlies) > change the value of permissions.default.image My setting was at 2. I changed it to 0. Remote images are now loading (despite your first step not applying - strange). Thanks! BTW: I have "block remote... unless in address book". I'll have to see if that setting is being respected...
My (In reply to comment #18) > I have neither a "pref" directory, nor a "thunderbird-all.js" file. :-\ My path is thunderbird\defaults\pref\thunderbird-all.js
I checked in this patch so at least new users won't get stuck. But if you downloaded a build that migrated the pref, then you are stuck unless you clear the pref by hand.
(In reply to comment #18) > (In reply to comment #16) > > implement that patch yourself to fix the problem: > > - edit <programdir>\pref\thunderbird-all.js > > I have neither a "pref" directory, nor a "thunderbird-all.js" file. :-\ I do, however, have an "all-thunderbird.js" file in my Thunderbird trunk install for Windows (Why the difference?). Editing the file yielded no noticeable effect. > BTW: I have "block remote... unless in address book". I'll have to see if that > setting is being respected... It seems to be working as expected.
*** Bug 340928 has been marked as a duplicate of this bug. ***
I followed the steps of 15 but now once I have selected "Show Images" for one email, it will show them for all. The Show Images button disappears completely. The normal behavior should be that it only disappears for that particular email. Did I miss some other setting?
I edited all.js Changed permissions.default.image to 3 and it seems that images are now being blocked / accepted as expected.
(In reply to comment #24) > I edited all.js > Changed permissions.default.image to 3 > and it seems that images are now being blocked / accepted as expected. > Restarted TB and everything is broken again.
(In reply to comment #25) > (In reply to comment #24) > > I edited all.js > > Changed permissions.default.image to 3 > > and it seems that images are now being blocked / accepted as expected. > > > > Restarted TB and everything is broken again. > Let me restate that. I upgraded to a new nightly build and restarted and all was broken again. The settings though have not been changed from the values I edited them to.
Still stuck on this one. I seem to be at a point where I can get the "Show Images" button to show up, but when I press it images don't load. For that email, the button then goes away, then for a new email, the button will appear again. This is the expected behavior but images never load.
Component: RSS → Preferences
QA Contact: rss → preferences
(In reply to comment #27) > Still stuck on this one. I seem to be at a point where I can get the "Show > Images" button to show up, but when I press it images don't load. For that > email, the button then goes away, then for a new email, the button will appear > again. This is the expected behavior but images never load. > Did you uncheck in the options panel: Privacy/general/Block loading of remote images in mail messages?
Yes and they still don't load. On the other hand, the desired behavior is to have that checked and images don't load until I approve them for a particular email.
(In reply to comment #29) > Yes and they still don't load. On the other hand, the desired behavior is to > have that checked and images don't load until I approve them for a particular > email. You are right. If I check this box, I get the "shows images" button. For me it works with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060625 Thunderbird/3.0a1 ID:2006062509 permissions.default.image is set to "0"
Argh, I'm still having to use a May build because I can't get around this.
I have had this behavior for some time now and only today got around to actually search Bugzilla for this bug. I trivially opened about:config and set permissions.default.image = 1 as it has been suggested, and the effect is to correct the issue. Restarting Thunderbird does not alter the setting. The problem appears to be fixed, so I propose to change the state to WORKSFORME (using TB version 3 alpha 1 20060904 on WinXP SP2).
(In reply to comment #32) > I have had this behavior for some time now and only today got around to > actually search Bugzilla for this bug. > > I trivially opened about:config and set > permissions.default.image = 1 > as it has been suggested, and the effect is to correct the issue. > Restarting Thunderbird does not alter the setting. > > The problem appears to be fixed, so I propose to change the state to WORKSFORME > (using TB version 3 alpha 1 20060904 on WinXP SP2). > I can confirm after changing the value of the permission, it fixes the problem. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060905 Minefield/3.0a1 ID:2006090504 [cairo]
Oops, I copied the wrong build string. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060905 Thunderbird/3.0a1 ID:2006090506
I have started seeing no images in RSS feeds as of Thunderbird 3 Alpha (Trunk Nightly, Windows) in 20061101 and 20061102 (this may have started earlier, I think I had downloaded no updates for several days prior to this).
(In reply to comment #35) > I have started seeing no images in RSS feeds as of Thunderbird 3 Alpha (Trunk > Nightly, Windows) in 20061101 and 20061102 (this may have started earlier, I > think I had downloaded no updates for several days prior to this). > Further to above - I didn't see the whole correspondence on this when I replied to this bug. I have now gone into Options, Privacy, General and unchecked "Block loading of remote images in mail messages" - which fixes the problem for me. I'm wondering whether this option could be altered so that it does not apply to News and Blogs folders? No idea how it came to get checked in the first place as I have not been near it and always got RSS images up to now!
(In reply to comment #36 [Peter Reynolds]) > (In reply to comment #35) > > I have started seeing no images in RSS feeds [...] > I have now gone into Options, Privacy, General and unchecked > "Block loading of remote images in mail messages" - which fixes the problem > for me. I'm wondering whether this option could be altered so that it does > not apply to News and Blogs folders? That setting is not supposed to apply to RSS at all (see bug 296258). I haven't tested with the specific versions you cite, but my current 3a1-0125 build is letting images thru in RSS while the 'block' preference is turned on. This bug involved a mistaken automatic pref-migration (comment 14 & 15) which (per comment 20) has been fixed. The only lingering effects of this would be for someone who ran a version from the regression period (May 26 thru June 4). In this case, after installing a more current trunk build, the only thing necessary to fix this is to change the setting of permissions.default.image as described in comment 16. Three reporters above confirmed that this was working for them; Mark Hulber was still having problems. Any reason to leave this bug open?
I had to uninstall completely and reinstall and then it was ok. Prior to this, no setting changes were otherwise working.
Now, many months later, remote images have disappeared from email messages I'm receiving. I'm using Thunderbird trunk nightly and they've been missing for about a week to 10 days. The Options, Privacy, General tab has now been removed from Thunderbird and I can't work out how to do the replacement method. The files Mozilla's help tells me to use seem to be empty!
Also the show images button has gone; and remote images are not shown even for people who I have in the Address Book marked "Allow remote images in HTML mail"
Peter: I'm not seeing it, but even if I were, i doubt it would be this bug. Scott: Any reason to leave this bug open? Comment 20 is a long time ago, I doubt many people have the original problem at this point.
I still don't get images no matter what even if I click the button to show images.
Did you try comment 32 (or comment #16)?
(In reply to comment #43) > Did you try comment 32 (or comment #16)? > I had the problem quite a long time ago. All of the referenced fixes didn't work but completely uninstalling and reinstalling worked fine and I haven't seen the issue again across several computers (see comment #38).
OK now fixed - not sure what I did but it was something to do with full html and simple html (in View, Message Body As), though that didn't solve it immediately. Sorry for bother.
Kurt's the only one who still had trouble and hasn't commented. So => fixed (comment 20)
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
I created a new profile and deleted the old a few months ago so I couldn't test...sorry forgot about this to confirm the fix or not.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: