Closed Bug 339105 Opened 16 years ago Closed 16 years ago

nsUnicharPtrHashKey

Categories

(Core :: XPCOM, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

nsUnicharPtrHashKey, basically copying nsCharPtrHashKey
Blocks: 339106
Attachment #223181 - Flags: review?(darin)
Comment on attachment 223181 [details] [diff] [review]
nsUnicharPtrHashKey, rev. 1

>Index: xpcom/glue/nsHashKeys.h

> NS_COM_GLUE PRUint32 HashString(const nsAString& aStr);
> NS_COM_GLUE PRUint32 HashString(const nsACString& aStr);
> NS_COM_GLUE PRUint32 HashCString(const char* aKey);
>+NS_COM_GLUE PRUint32 HashString(const PRUnichar* aKey);

nit: It seems to me that either these should all be called HashString
or the nsACString version should be called HashCString.


r=darin
Attachment #223181 - Flags: review?(darin) → review+
Fixed on trunk, making all the signatures "HashString"
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.