339105 - nsUnicharPtrHashKey

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benjamin Smedberg]

nsUnicharPtrHashKey, basically copying nsCharPtrHashKey

Comment 1

[Benjamin Smedberg]

Attachment: nsUnicharPtrHashKey, rev. 1

Comment 2

[Darin Fisher]

Comment on attachment 223181 [details] [diff] [review]
nsUnicharPtrHashKey, rev. 1

>Index: xpcom/glue/nsHashKeys.h

> NS_COM_GLUE PRUint32 HashString(const nsAString& aStr);
> NS_COM_GLUE PRUint32 HashString(const nsACString& aStr);
> NS_COM_GLUE PRUint32 HashCString(const char* aKey);
>+NS_COM_GLUE PRUint32 HashString(const PRUnichar* aKey);

nit: It seems to me that either these should all be called HashString
or the nsACString version should be called HashCString.


r=darin

Comment 3

[Benjamin Smedberg]

Fixed on trunk, making all the signatures "HashString"