Closed
Bug 339105
Opened 19 years ago
Closed 19 years ago
nsUnicharPtrHashKey
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
3.64 KB,
patch
|
darin.moz
:
review+
|
Details | Diff | Splinter Review |
nsUnicharPtrHashKey, basically copying nsCharPtrHashKey
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #223181 -
Flags: review?(darin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 223181 [details] [diff] [review]
nsUnicharPtrHashKey, rev. 1
>Index: xpcom/glue/nsHashKeys.h
> NS_COM_GLUE PRUint32 HashString(const nsAString& aStr);
> NS_COM_GLUE PRUint32 HashString(const nsACString& aStr);
> NS_COM_GLUE PRUint32 HashCString(const char* aKey);
>+NS_COM_GLUE PRUint32 HashString(const PRUnichar* aKey);
nit: It seems to me that either these should all be called HashString
or the nsACString version should be called HashCString.
r=darin
Attachment #223181 -
Flags: review?(darin) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk, making all the signatures "HashString"
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•