339151 - Folder Properties Retention Policy tab dialog needs to be re-worded (grammar)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Lewis Rosenthal]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a1) Gecko/20060522 MultiZilla/1.8.2.0i SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a1) Gecko/20060522 MultiZilla/1.8.2.0i SeaMonkey/1.5a

The Retention Policy tab in the Folder Properties dialog lists the third radio button text as:

     Messages which have arrived with the last __ days old

The word "old" is extraneous and should be removed, making the text read:

     Messages which have arrived with the last __ days


Reproducible: Always

Steps to Reproduce:
1. Right-click any mail folder.
2. Select Properties.
3. Click on Retention Policy tab.

Actual Results:  
Grammar is poor (incorrect)

Expected Results:  
Grammar should be correct. :)

Comment 1

[u31731]

Confirming this in both SeaMonkey 1.0.2 and 1.5a. In addition, the [wrong] words "days old" appears to be positioned higher than the option's line of text located before the [nn] entry box. Can anyone else confirm the text position?

Comment 2

[u31731]

Sorry for the additional spam, but I found that Bug 307058 (Thunderbird) is closely related to this bug, and that the fix checked-in from Bug 299550 is likely what broke SeaMonkey builds. This should be an easy fix.

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008051803 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

TB asks for what to delete.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060902 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

While SM asks for what to keep.

Hence, they can't share the same (xul) code :-/
Or maybe they do share it, but the SM code and/or strings were not updated to match TB' ?

At least, we need to check what is actually going on ! ("asap")

Comment 4

[[e-mail]]

What happened here was that the patch in bug 11055 had the wrong set of strings for the suite version of folderProps.dtd (the tb version and both versions of am-offline.dtd seem to use the correct strings).

KaiRo, what's the branch l10n impact here?

Comment 5

[Robert Kaiser]

Ugh. Branch should be 100% string frozen, but this is obviously a real bug. That's really bad. If we don't correct it, we have wrong UI, if we correct it, we break the promise to all localizers that language packs work for the whole 1.1.x series and we might lose a substantial number of available localizations as not all of them update their packages for every SeaMonkey release.

Even on trunk, this would call for a string ID change, but I guess this can't be done without changing the Thunderbird string ID as well. 

This whole issue sucks bad time. Poor developers and reviewers of bug 11055 who are to blame for this.

Comment 6

[Ian Neal]

Attachment: Change entity names and correct string for SeaMonkey (Checkin: Comment 7)

This patch:
* Changes the label/accesskey names in folderProps.xul
* Changes entity names in dtd files
* Corrects label entity string for SeaMonkey to be the same as it is in Thunderbird

Would like to get this in before string freeze

Comment 7

[Ian Neal]

Comment on attachment 334122 [details] [diff] [review]
Change entity names and correct string for SeaMonkey (Checkin: Comment 7)

http://hg.mozilla.org/comm-central/index.cgi/rev/e4f3e00f2324