339192 - Readonly textboxes shouldn't look active

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[Phil Ringnalda (:philor)]

Currently, only Windows (both sorts for XUL, Luna for HTML) shows readonly textboxes any differently than regular active ones: there, they have the same gray (well, threedface) background as disabled textboxes, but for Mac (and GTK) they are just a frustratingly broken field where you can't type.

Apparently, judging by the lack of bugs, it's not much of a problem in HTML, but we've got at least two consumers in XUL (bug 297815 and bug 337344) that need at least some hint that there's a reason why you can't change the value, just copy it.

Testcases and patch forthcoming.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: HTML testcase

Comment 2

[Phil Ringnalda (:philor)]

Attachment: XUL testcase

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

I'm not quite sure about the style of this, but it works, in Firefox for XUL, and CocoaFox and Camino for HTML.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: HTML screenshot

Camino, CocoaFox, and Safari rendering the HTML testcase with my patch applied.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 223269 [details] [diff] [review]
Fix v.1

sr=pink

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/widget/src/mac/nsNativeThemeMac.cpp 	1.51

Comment 7

[Mark Mentovai]

Phil, do you intend to seek 1.8.1 approval for this?  I'd take it.

Comment 8

[Phil Ringnalda (:philor)]

I do (it's a blocker for a Firefox 2.0 blocker), I just wanted a little baking since I don't use Cocoa widgets in HTML for daily browsing, so I wanted to see if it screwed up something I hadn't noticed.

Plus I'm still confused over who does which reviews for whom here ;) How about if I request a= from you, and you can pass it off if that's not right?

Comment 9

[Mark Mentovai]

Comment on attachment 223269 [details] [diff] [review]
Fix v.1

Good call!  Module owners can grant 1.8.1 approval until June 15, or at least that was the plan a few days ago.

Comment 10

[Asaf Romano (gone)]

1.8: Checking in mozilla/gfx/src/mac/nsNativeThemeMac.cpp;
/cvsroot/mozilla/gfx/src/mac/Attic/nsNativeThemeMac.cpp,v  <--  nsNativeThemeMac.cpp
new revision: 1.40.2.2; previous revision: 1.40.2.1
done